Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
4.03k stars 3.03k forks source link

Update the Export icon in report details page #55736

Closed Shahidullah-Muffakir closed 1 week ago

Shahidullah-Muffakir commented 2 weeks ago

Explanation of Change

Updated the report details page to use the correct Export icon.

Fixed Issues

$ https://github.com/Expensify/App/issues/55342 PROPOSAL: https://github.com/Expensify/App/issues/55342#issuecomment-2597024627

Tests

  1. Open the report details page
  2. Verify that the correct icon is displayed for Export

Offline tests

  1. Open the report details page
  2. Verify that the correct icon is displayed for Export

QA Steps

  1. Open the report details page
  2. Verify that the correct icon is displayed for Export

PR Author Checklist

Screenshots/Videos

Android: Native I have build issue, anyway the change is platform independent.
Android: mWeb Chrome android web
iOS: Native ios native
iOS: mWeb Safari ios safri
MacOS: Chrome / Safari macos chrome
MacOS: Desktop Screenshot 2025-01-24 at 9 31 59 PM
melvin-bot[bot] commented 2 weeks ago

@fedirjh Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

dannymcclain commented 2 weeks ago

Screenshots look good to me!

shawnborton commented 2 weeks ago

Same!

fedirjh commented 2 weeks ago

Reviewer Checklist

Screenshots/Videos

Android: Native Screenshot 2025-01-25 at 3 25 26 PM
Android: mWeb Chrome Screenshot 2025-01-25 at 3 15 18 PM
iOS: Native Screenshot 2025-01-25 at 4 30 13 PM
iOS: mWeb Safari Screenshot 2025-01-25 at 3 35 13 PM
MacOS: Chrome / Safari Screenshot 2025-01-25 at 3 04 09 PM
MacOS: Desktop Screenshot 2025-01-25 at 3 12 48 PM
OSBotify commented 1 week ago

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions[bot] commented 1 week ago

🚀 Deployed to staging by https://github.com/lakchote in version: 9.0.95-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅
🤖🔄 android HybridApp 🤖🔄 success ✅
🍎🔄 iOS HybridApp 🍎🔄 success ✅
github-actions[bot] commented 3 days ago

🚀 Deployed to production by https://github.com/Julesssss in version: 9.0.95-6 🚀

platform result
🤖 android 🤖 true ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅
🤖🔄 android HybridApp 🤖🔄 failure ❌
🍎🔄 iOS HybridApp 🍎🔄 failure ❌