Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
4.03k stars 3.03k forks source link

Fix Webpack configuration to use the minified pdf.worker file #55743

Closed rezkiy37 closed 3 weeks ago

rezkiy37 commented 3 weeks ago

Explanation of Change

The PR fixes Webpack configuration to use the minified pdf.worker file and align it with the PDFThumbnail. https://github.com/Expensify/App/pull/55421#issuecomment-2612925631

Fixed Issues

$ https://github.com/Expensify/App/issues/55176 PROPOSAL: N/A

Tests

  1. Run web.
  2. Check Webpack logs.
  3. Verify that there is no the error associated with the pdf worker.
  4. Open any pdf file.
  5. Verify the app renders it properly.
  6. Verify no errors or warnings.
Screenshot

Logs

Offline tests

Same as tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

  1. Open any pdf file.
  2. Verify the app renders it properly.

PR Author Checklist

Screenshots/Videos

Android: Native ![Android](https://github.com/user-attachments/assets/a0b902ab-c712-4a5d-bbeb-90ab9022fb13)
Android: mWeb Chrome ![Android Chrome](https://github.com/user-attachments/assets/6a30eb10-fb9e-4d0e-928a-317f850d1a77)
iOS: Native IOS
iOS: mWeb Safari IOS Safari 2 IOS Safari
MacOS: Chrome / Safari Chrome
MacOS: Desktop Desktop
melvin-bot[bot] commented 3 weeks ago

@jjcoffee Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

mountiny commented 3 weeks ago

Reviewer Checklist

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop
OSBotify commented 3 weeks ago

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

kavimuru commented 2 weeks ago

Can you help with the following steps?

  1. Run web.
  2. Check Webpack logs.
  3. Verify that there is no the error associated with the pdf worker.
github-actions[bot] commented 2 weeks ago

🚀 Deployed to staging by https://github.com/mountiny in version: 9.0.90-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅
🤖🔄 android HybridApp 🤖🔄 success ✅
🍎🔄 iOS HybridApp 🍎🔄 success ✅
rezkiy37 commented 2 weeks ago

Can you help with the following steps?

  1. Run web.
  2. Check Webpack logs.
  3. Verify that there is no the error associated with the pdf worker.

Yes, I can.

  1. Open the terminal.
  2. Go to the root of the project.
  3. Run npm run web.
  4. Verify that there are no errors associated with the pdf worker.

@kavimuru, does it make sense?

mountiny commented 2 weeks ago

@rezkiy37 qa should just check the pdf works in safari

rezkiy37 commented 2 weeks ago

@mountiny, you are right. I left other steps for QA 🤔

Screenshot 2025-01-28 at 16 13 14
mountiny commented 2 weeks ago

@kavimuru just check that the pdf attachments are showing correctly in mweb safari

github-actions[bot] commented 2 weeks ago

🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.0.90-6 🚀

platform result
🤖 android 🤖 true ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅
🤖🔄 android HybridApp 🤖🔄 failure ❌
🍎🔄 iOS HybridApp 🍎🔄 success ✅