Closed rezkiy37 closed 3 weeks ago
@jjcoffee Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]
### Fixed Issues
section aboveTests
sectionQA steps
sectiontoggleReport
and not onIconClick
).src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components using Avatar
have been tested & I retested again)/** comment above it */
this
properly so there are no scoping issues (i.e. for onClick={this.submit}
the method this.submit
should be bound to this
in the constructor)this
are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this);
if this.submit
is never passed to a component event handler like onClick
)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG
)Avatar
is modified, I verified that Avatar
is working as expected in all cases)Design
label and/or tagged @Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test
steps.:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.
Can you help with the following steps?
🚀 Deployed to staging by https://github.com/mountiny in version: 9.0.90-0 🚀
platform | result |
---|---|
🤖 android 🤖 | success ✅ |
🖥 desktop 🖥 | success ✅ |
🍎 iOS 🍎 | success ✅ |
🕸 web 🕸 | success ✅ |
🤖🔄 android HybridApp 🤖🔄 | success ✅ |
🍎🔄 iOS HybridApp 🍎🔄 | success ✅ |
Can you help with the following steps?
- Run web.
- Check Webpack logs.
- Verify that there is no the error associated with the pdf worker.
Yes, I can.
npm run web
.@kavimuru, does it make sense?
@rezkiy37 qa should just check the pdf works in safari
@mountiny, you are right. I left other steps for QA 🤔
@kavimuru just check that the pdf attachments are showing correctly in mweb safari
🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.0.90-6 🚀
platform | result |
---|---|
🤖 android 🤖 | true ❌ |
🖥 desktop 🖥 | success ✅ |
🍎 iOS 🍎 | success ✅ |
🕸 web 🕸 | success ✅ |
🤖🔄 android HybridApp 🤖🔄 | failure ❌ |
🍎🔄 iOS HybridApp 🍎🔄 | success ✅ |
Explanation of Change
The PR fixes Webpack configuration to use the minified pdf.worker file and align it with the PDFThumbnail. https://github.com/Expensify/App/pull/55421#issuecomment-2612925631
Fixed Issues
$ https://github.com/Expensify/App/issues/55176 PROPOSAL: N/A
Tests
Screenshot
Offline tests
Same as tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop