Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
4.03k stars 3.03k forks source link

[$250] iOS Hybrid - Sign in - The app does not auto suggest the magic code from email to sign in #55744

Open vincdargento opened 3 weeks ago

vincdargento commented 3 weeks ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue was found while executing QA for PR #54755

Version Number: 9.0.89.5 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: No, reproducible on hybrid only If this was caught during regression testing, add the test name, ID and link from TestRail: https://github.com/Expensify/App/pull/54755 Email or phone of affected tester (no customers): N/A Issue reported by: Applause Internal Team Device used: iPhone 15 iOS 18.1.1 App Component: Other

Action Performed:

  1. Open staging Hybrid app
  2. Select Continue with Email option on the Welcome screen
  3. Enter the email address that is added to your iOS mail app
  4. Tap Next
  5. Open the mail app and wait for the code to arrive, don't open it
  6. Go back to the Hybrid app and make sure that it auto suggests the magic code

Expected Result:

Hybrid app auto suggests the magic code from the email to sign in with, as in ND Standalone app.

Actual Result:

Hybrid app does not auto suggest the magic code from email to sign in

Workaround:

Unknown

Platforms:

Screenshots/Videos

https://github.com/user-attachments/assets/51742953-307d-4372-8cdf-78ac1148f333

https://github.com/user-attachments/assets/34fec303-3cfd-4487-8f54-a7e513c40a9a

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021884130584906000105
  • Upwork Job ID: 1884130584906000105
  • Last Price Increase: 2025-01-28
  • Automatic offers:
    • brunovjk | Reviewer | 105889014
Issue OwnerCurrent Issue Owner: @brunovjk
melvin-bot[bot] commented 3 weeks ago

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

melvin-bot[bot] commented 2 weeks ago

Job added to Upwork: https://www.upwork.com/jobs/~021884130584906000105

melvin-bot[bot] commented 2 weeks ago

Triggered auto assignment to Contributor-plus team member for initial proposal review - @brunovjk (External)

hannojg commented 2 weeks ago

This screen:

Image

Is part of the old app's code (https://github.com/Expensify/Mobile-Expensify), thus it's not a bug from this code base.

hannojg commented 2 weeks ago

Not sure if issues for the old app's code are tracked in this repository?

melvin-bot[bot] commented 2 weeks ago

📣 @brunovjk 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link Upwork job

brunovjk commented 2 weeks ago

I'm having a hard time reproducing this issue, I still haven't been able to install "mail app" on my simulator.

mountiny commented 2 weeks ago

@hannojg have you been able to setup the hybrid app and look into this?

melvin-bot[bot] commented 1 week ago

@hannojg @stephanieelliott @mountiny @brunovjk this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

stephanieelliott commented 5 days ago

Hey @brunovjk, any luck looking into this yet?

brunovjk commented 5 days ago

Not yet @stephanieelliott, I still haven't been able to reproduce it because of the iOS Mail App, today I'll try some alternative ways and let you know. Thanks.