Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
4.03k stars 3.03k forks source link

[$250] Company cards - Netsuite - Card details page opened when going back from Netsuite Export settings page #55752

Open vincdargento opened 3 weeks ago

vincdargento commented 3 weeks ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v9.0.89-5 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Email or phone of affected tester (no customers): applausetester+ccardfeed@applause.expensifail.com Issue reported by: Applause Internal Team Device used: Windows 10 / Chrome App Component: Workspace Settings

Action Performed:

Pre-requisite:

  1. Go to Workspace settings > Company cards
  2. Click on an assigned card
  3. Click on the export option row (vendor bill, journal entries)
  4. Click on "export option" highlighted text in the subheader.
  5. Click on the back arrow.

Expected Result:

User should land on the card-level export page

Actual Result:

User lands in the card details page

Workaround:

Unknown

Platforms:

Screenshots/Videos

https://github.com/user-attachments/assets/3325d065-dd12-4273-8e35-b3dbdb50a6fa

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021883948962200015407
  • Upwork Job ID: 1883948962200015407
  • Last Price Increase: 2025-01-27
  • Automatic offers:
    • FitseTLT | Contributor | 105928754
Issue OwnerCurrent Issue Owner: @mananjadhav
melvin-bot[bot] commented 3 weeks ago

Triggered auto assignment to @maddylewis (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

isagoico commented 3 weeks ago

@joekaufmanexpensify We found this issue when writing the TestRail regression steps for Company Cards

FitseTLT commented 3 weeks ago

Proposal

Please re-state the problem that we are trying to solve in this issue.

Company cards - Netsuite - Card details page opened when going back from Netsuite Export settings page

What is the root cause of that problem?

We are passing the backTo of WorkspaceCompanyCardAccountSelectCardPage for the menu items here https://github.com/Expensify/App/blob/fc199faf777dc7f1710b3d5cb4ab7abf6106309c/src/pages/workspace/companyCards/WorkspaceCompanyCardAccountSelectCardPage.tsx#L39

What changes do you think we should make in order to solve the problem?

We should pass the current active route as the backTo

    const exportMenuItem = getExportMenuItem(connectedIntegration, policyID, translate, policy, card, Navigation.getActiveRoute());

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

What alternative solutions did you explore? (Optional)

melvin-bot[bot] commented 2 weeks ago

Job added to Upwork: https://www.upwork.com/jobs/~021883948962200015407

melvin-bot[bot] commented 2 weeks ago

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

mananjadhav commented 2 weeks ago

@FitseTLT's proposal looks good to me.

πŸŽ€ πŸ‘€ πŸŽ€ C+ reviewed

melvin-bot[bot] commented 2 weeks ago

Triggered auto assignment to @carlosmiceli, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

melvin-bot[bot] commented 2 weeks ago

πŸ“£ @FitseTLT πŸŽ‰ An offer has been automatically sent to your Upwork account for the Contributor role πŸŽ‰ Thanks for contributing to the Expensify app!

Offer link Upwork job Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review πŸ§‘β€πŸ’» Keep in mind: Code of Conduct | Contributing πŸ“–

maddylewis commented 2 days ago

@FitseTLT @mananjadhav - can you provide an update on the status of this issue? tysm!

FitseTLT commented 2 days ago

PR drafted will upload snapshots and make it ready for review shortly