Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
4.03k stars 3.03k forks source link

[$250] Company cards - Netsuite - Wrong account name in preview for journal entries accounts #55753

Open vincdargento opened 3 weeks ago

vincdargento commented 3 weeks ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v9.0.89-5 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Email or phone of affected tester (no customers): applausetester+ccardfeed@applause.expensifail.com Issue reported by: Applause Internal Team Device used: Windows 10 / Chrome App Component: Workspace Settings

Action Performed:

Pre-requisite:

  1. Go to Workspace settings > Company cards
  2. Click on an assigned card
  3. Click on NetSuite vendor bills export
  4. Click on "export option" highlighted text in the subheader
  5. Click on "Export company card expenses as:" field
  6. Click on "Export as:"
  7. Select Journal entries
  8. Go back to card details
  9. Click on NetSuite journal entries export
  10. Click on a different account, note the displayed name
  11. Verify the selected account in the preview

Expected Result:

The name of the journal entry account displayed in the preview should be the same as in the list

Actual Result:

The name of the journal entry account displayed in the preview is not the same as in the list

Workaround:

Unknown

Platforms:

Screenshots/Videos

https://github.com/user-attachments/assets/54ca9f48-04db-4273-88aa-9f8e52dd56f8

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021885426285334547544
  • Upwork Job ID: 1885426285334547544
  • Last Price Increase: 2025-01-31
  • Automatic offers:
    • shubham1206agra | Contributor | 106076552
Issue OwnerCurrent Issue Owner: @mollfpr
melvin-bot[bot] commented 3 weeks ago

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

isagoico commented 3 weeks ago

@joekaufmanexpensify We found this issue when writing the TestRail regression steps for Company Cards

shubham1206agra commented 3 weeks ago

🚨 Edited by proposal-police: This proposal was edited at 2025-01-24 21:37:47 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Company cards - Netsuite - Wrong account name in preview for journal entries accounts

What is the root cause of that problem?

In

https://github.com/Expensify/App/blob/f4c3726afb57c388c88985a3930c2908bf5f4c71/src/pages/workspace/companyCards/utils.tsx#L20

We accidentally override title in this case shown below

https://github.com/Expensify/App/blob/f4c3726afb57c388c88985a3930c2908bf5f4c71/src/pages/workspace/companyCards/utils.tsx#L202

Which causes the wrong account name in preview.

What changes do you think we should make in order to solve the problem?

Remove

https://github.com/Expensify/App/blob/f4c3726afb57c388c88985a3930c2908bf5f4c71/src/pages/workspace/companyCards/utils.tsx#L202

to fix the issue.

Result

https://github.com/user-attachments/assets/035e22ac-62be-4d14-ba43-4838527b5aa5

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

NA since this is a UI bug

What alternative solutions did you explore? (Optional)

github-actions[bot] commented 3 weeks ago

⚠️ Thanks for your proposal. Please update it to follow the proposal template, as proposals are only reviewed if they follow that format (note the mandatory sections).

joekaufmanexpensify commented 3 weeks ago

Agreed, this seems like a bug.

melvin-bot[bot] commented 2 weeks ago

@abekkala Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

melvin-bot[bot] commented 2 weeks ago

@abekkala Eep! 4 days overdue now. Issues have feelings too...

melvin-bot[bot] commented 2 weeks ago

Job added to Upwork: https://www.upwork.com/jobs/~021885426285334547544

melvin-bot[bot] commented 2 weeks ago

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (External)

mollfpr commented 1 week ago

I agree with @shubham1206agra proposal. We probably forget to remove that line in this PR https://github.com/Expensify/App/pull/52575.

πŸŽ€ πŸ‘€ πŸŽ€ C+ reviewed!

melvin-bot[bot] commented 1 week ago

Triggered auto assignment to @lakchote, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

melvin-bot[bot] commented 1 week ago

@abekkala @lakchote @mollfpr this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

melvin-bot[bot] commented 1 week ago

@abekkala, @lakchote, @mollfpr Whoops! This issue is 2 days overdue. Let's get this updated quick!

mollfpr commented 6 days ago

Friendly bump @lakchote πŸ‘€

lakchote commented 5 days ago

@shubham1206agra's proposal LGTM.

melvin-bot[bot] commented 5 days ago

πŸ“£ @shubham1206agra πŸŽ‰ An offer has been automatically sent to your Upwork account for the Contributor role πŸŽ‰ Thanks for contributing to the Expensify app!

Offer link Upwork job Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review πŸ§‘β€πŸ’» Keep in mind: Code of Conduct | Contributing πŸ“–

abekkala commented 4 days ago

@shubham1206agra do you have a timeframe on the PR?

melvin-bot[bot] commented 2 days ago

@abekkala, @lakchote, @mollfpr, @shubham1206agra Whoops! This issue is 2 days overdue. Let's get this updated quick!

mollfpr commented 2 days ago

@shubham1206agra Any update on the PR?