Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
4.03k stars 3.03k forks source link

[High] [$250] Travel - Trip preview display 0 amount until open trip expenses #55754

Closed IuliiaHerets closed 4 days ago

IuliiaHerets commented 3 weeks ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v9.0.89-5 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught during regression testing, add the test name, ID and link from TestRail: https://github.com/Expensify/App/pull/55264 Email or phone of affected tester (no customers): - Issue reported by: Applause Internal Team Device used: Windows 11 / Chrome App Component: Chat Report View

Action Performed:

Precondition: trip is created (any type: flight/car rent/hotel)

  1. Open workspace chat
  2. Click Trip preview
  3. Pay elsewhere trip expense
  4. Go to Settings > Troubleshoot
  5. Clear cache and restart
  6. Open workspace chat

Expected Result:

Trip expense preview displays correct amount

Actual Result:

Trip expense preview displays 0 amount

NOTE: user has to click View Trip, open paid expenses and go back to parent ws chat to see correct amount.

Workaround:

Unknown

Platforms:

Screenshots/Videos

https://github.com/user-attachments/assets/bcdfc3c3-1d6b-4cfd-a321-ee1bfa5baf0e

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021883933166442762799
  • Upwork Job ID: 1883933166442762799
  • Last Price Increase: 2025-01-27
Issue OwnerCurrent Issue Owner: @cristipaval
melvin-bot[bot] commented 3 weeks ago

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

shubham1206agra commented 3 weeks ago

@cristipaval Pinging you here since last time you fixed this issue.

melvin-bot[bot] commented 2 weeks ago

Job added to Upwork: https://www.upwork.com/jobs/~021883933166442762799

melvin-bot[bot] commented 2 weeks ago

Triggered auto assignment to Contributor-plus team member for initial proposal review - @c3024 (External)

cristipaval commented 2 weeks ago

Ok, this is an interesting one! Here's what I found:

So, I think that loading all linked reports with their transactions for each TRIPPREVIEW action might be an overkill and we need to think about a more performant solution. One rough idea would be to add the tripID to the receipt with the reservationList and to the TRIPPREVIEW actions and match by that instead of loading all the linked reports 🤷‍♂

I'll do more investigation tomorrow with a fresh brain.

cristipaval commented 2 weeks ago

One rough idea would be to add the tripID to the receipt with the reservationList and to the TRIPPREVIEW actions and match by that instead of loading all the linked reports 🤷‍♂

@stitesExpensify, do you know whether the tripID might change for a receipt/transaction? If it can change, then I think it might be a pain in the ass to keep it up to date in all clients with Onyx updates 🤔

cristipaval commented 2 weeks ago

I chatted with @rlinoz about this issue and we think it is not an overkill to load the linked reports together with the transactions for the TRIPPREVIEW actions because:

stitesExpensify commented 2 weeks ago

@stitesExpensify, do you know whether the tripID might change for a receipt/transaction? If it can change, then I think it might be a pain in the ass to keep it up to date in all clients with Onyx updates 🤔

I don't see anything in the UI, maybe support agents can do that though?

cristipaval commented 2 weeks ago

@stitesExpensify , I added this issue to the Travel project board. Feel free to remove/change the priority if what I set is wrong

cristipaval commented 4 days ago

This is in prod