Closed maddylewis closed 2 weeks ago
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member?
cc @laurenreidexpensify
@pecanoro @laurenreidexpensify One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]
A preview of your ExpensifyHelp changes have been deployed to https://67d89037.helpdot.pages.dev ā”ļø
hmmm ill update the redirect and then let you know once this is ready to merge
waiting for a few other PRs to be merged that required redirects to avoid conflicts, and then ill create a redirect for this one.
### Fixed Issues
section aboveTests
sectionQA steps
sectiontoggleReport
and not onIconClick
).myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components using Avatar
have been tested & I retested again)/** comment above it */
this
properly so there are no scoping issues (i.e. for onClick={this.submit}
the method this.submit
should be bound to this
in the constructor)this
are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this);
if this.submit
is never passed to a component event handler like onClick
)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG
)Avatar
is modified, I verified that Avatar
is working as expected in all cases)Design
label so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test
steps.@maddylewis I am getting this so I am not sure if I can merge it:
ope yes @pecanoro - i gotta update something in the redirect file https://github.com/Expensify/App/pull/55756#issuecomment-2616070221
ill ping ya once that's all set and ready for you to merge :)
looks like this one is good to merge now @pecanoro
@pecanoro i think i could merge but i am scared i will mess something up. will you do the honors and merge this one?
š Deployed to staging by https://github.com/pecanoro in version: 9.0.90-0 š
platform | result |
---|---|
š¤ android š¤ | success ā |
š„ desktop š„ | success ā |
š iOS š | success ā |
šø web šø | success ā |
š¤š android HybridApp š¤š | success ā |
šš iOS HybridApp šš | success ā |
š Deployed to production by https://github.com/yuwenmemon in version: 9.0.90-6 š
platform | result |
---|---|
š¤ android š¤ | true ā |
š„ desktop š„ | success ā |
š iOS š | success ā |
šø web šø | success ā |
š¤š android HybridApp š¤š | failure ā |
šš iOS HybridApp šš | success ā |
https://github.com/Expensify/Expensify/issues/460782
Explanation of Change
Fixed Issues
$ PROPOSAL:
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videosundefined