Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
4.03k stars 3.03k forks source link

[No QA] Update SAML-SSO.md #55756

Closed maddylewis closed 2 weeks ago

maddylewis commented 3 weeks ago

https://github.com/Expensify/Expensify/issues/460782

Explanation of Change

Fixed Issues

$ PROPOSAL:

Tests

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

PR Author Checklist

melvin-bot[bot] commented 3 weeks ago

Concierge reviewer checklist:

For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member?

cc @laurenreidexpensify

melvin-bot[bot] commented 3 weeks ago

@pecanoro @laurenreidexpensify One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

OSBotify commented 3 weeks ago

A preview of your ExpensifyHelp changes have been deployed to https://67d89037.helpdot.pages.dev āš”ļø

maddylewis commented 2 weeks ago

hmmm ill update the redirect and then let you know once this is ready to merge

maddylewis commented 2 weeks ago

waiting for a few other PRs to be merged that required redirects to avoid conflicts, and then ill create a redirect for this one.

pecanoro commented 2 weeks ago

Reviewer Checklist

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop
pecanoro commented 2 weeks ago

@maddylewis I am getting this so I am not sure if I can merge it:

image

maddylewis commented 2 weeks ago

ope yes @pecanoro - i gotta update something in the redirect file https://github.com/Expensify/App/pull/55756#issuecomment-2616070221

ill ping ya once that's all set and ready for you to merge :)

maddylewis commented 2 weeks ago

looks like this one is good to merge now @pecanoro

maddylewis commented 2 weeks ago

@pecanoro i think i could merge but i am scared i will mess something up. will you do the honors and merge this one?

github-actions[bot] commented 2 weeks ago

šŸš€ Deployed to staging by https://github.com/pecanoro in version: 9.0.90-0 šŸš€

platform result
šŸ¤– android šŸ¤– success āœ…
šŸ–„ desktop šŸ–„ success āœ…
šŸŽ iOS šŸŽ success āœ…
šŸ•ø web šŸ•ø success āœ…
šŸ¤–šŸ”„ android HybridApp šŸ¤–šŸ”„ success āœ…
šŸŽšŸ”„ iOS HybridApp šŸŽšŸ”„ success āœ…
github-actions[bot] commented 2 weeks ago

šŸš€ Deployed to production by https://github.com/yuwenmemon in version: 9.0.90-6 šŸš€

platform result
šŸ¤– android šŸ¤– true āŒ
šŸ–„ desktop šŸ–„ success āœ…
šŸŽ iOS šŸŽ success āœ…
šŸ•ø web šŸ•ø success āœ…
šŸ¤–šŸ”„ android HybridApp šŸ¤–šŸ”„ failure āŒ
šŸŽšŸ”„ iOS HybridApp šŸŽšŸ”„ success āœ