Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
4.03k stars 3.03k forks source link

[NO QA] Update redirects.csv #55757

Closed jamesdeanexpensify closed 3 weeks ago

jamesdeanexpensify commented 3 weeks ago

Redirecting from a broken link

Explanation of Change

Fixed Issues

$ PROPOSAL:

Tests

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

PR Author Checklist

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop
melvin-bot[bot] commented 3 weeks ago

Concierge reviewer checklist:

For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member?

cc @bfitzexpensify

melvin-bot[bot] commented 3 weeks ago

@rlinoz @bfitzexpensify One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

NOTE: It looks like docs/redirects.csv was modified in this PR. Please see this SO for special instructions on how to review changes to that file.

jamesdeanexpensify commented 3 weeks ago

Oh shoot I might've created this too early - I want to make sure I'm redirecting the broken link to the correct place.

jamesdeanexpensify commented 3 weeks ago

Or @bfitzexpensify is that something you could buddy check?

OSBotify commented 3 weeks ago

A preview of your ExpensifyHelp changes have been deployed to https://06e1a3a7.helpdot.pages.dev โšก๏ธ

bfitzexpensify commented 3 weeks ago

Reviewer Checklist

melvin-bot[bot] commented 3 weeks ago

@bfitzexpensify looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

bfitzexpensify commented 3 weeks ago

Oh boy, what did I do? ๐Ÿ˜…

Defs not an emergency - label removed.

@rlinoz what did I miss?

rlinoz commented 2 weeks ago

Oh apparently not all jobs ran successfully

This is the one that was failing https://github.com/Expensify/App/actions/runs/12958437940/job/36148852073

rlinoz commented 2 weeks ago

@jamesdeanexpensify @bfitzexpensify We have to remove this line https://github.com/Expensify/App/blob/aa44d5c3745fb5792eba9ce0cd983ee502111157/docs/redirects.csv#L615 of the redirects.csv file so we don't have duplicates.

jamesdeanexpensify commented 2 weeks ago

Thanks @rlinoz ! Should I do this in a separate PR?

rlinoz commented 2 weeks ago

Yes, please!

jamesdeanexpensify commented 2 weeks ago

Wait did that line.....disappear?

rlinoz commented 2 weeks ago

Ah @stitesExpensify fixed it here https://github.com/Expensify/App/pull/55800, thanks! ๐Ÿ™‡

jamesdeanexpensify commented 2 weeks ago

Amazing, yes thank you!

github-actions[bot] commented 2 weeks ago

๐Ÿš€ Deployed to staging by https://github.com/bfitzexpensify in version: 9.0.90-0 ๐Ÿš€

platform result
๐Ÿค– android ๐Ÿค– success โœ…
๐Ÿ–ฅ desktop ๐Ÿ–ฅ success โœ…
๐ŸŽ iOS ๐ŸŽ success โœ…
๐Ÿ•ธ web ๐Ÿ•ธ success โœ…
๐Ÿค–๐Ÿ”„ android HybridApp ๐Ÿค–๐Ÿ”„ success โœ…
๐ŸŽ๐Ÿ”„ iOS HybridApp ๐ŸŽ๐Ÿ”„ success โœ…
github-actions[bot] commented 2 weeks ago

๐Ÿš€ Deployed to production by https://github.com/yuwenmemon in version: 9.0.90-6 ๐Ÿš€

platform result
๐Ÿค– android ๐Ÿค– true โŒ
๐Ÿ–ฅ desktop ๐Ÿ–ฅ success โœ…
๐ŸŽ iOS ๐ŸŽ success โœ…
๐Ÿ•ธ web ๐Ÿ•ธ success โœ…
๐Ÿค–๐Ÿ”„ android HybridApp ๐Ÿค–๐Ÿ”„ failure โŒ
๐ŸŽ๐Ÿ”„ iOS HybridApp ๐ŸŽ๐Ÿ”„ success โœ