Closed jamesdeanexpensify closed 3 weeks ago
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member?
cc @bfitzexpensify
@rlinoz @bfitzexpensify One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]
NOTE: It looks like docs/redirects.csv
was modified in this PR. Please see this SO for special instructions on how to review changes to that file.
Oh shoot I might've created this too early - I want to make sure I'm redirecting the broken link to the correct place.
Or @bfitzexpensify is that something you could buddy check?
A preview of your ExpensifyHelp changes have been deployed to https://06e1a3a7.helpdot.pages.dev โก๏ธ
### Fixed Issues
section aboveTests
sectionQA steps
sectiontoggleReport
and not onIconClick
).src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components using Avatar
have been tested & I retested again)/** comment above it */
this
properly so there are no scoping issues (i.e. for onClick={this.submit}
the method this.submit
should be bound to this
in the constructor)this
are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this);
if this.submit
is never passed to a component event handler like onClick
)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG
)Avatar
is modified, I verified that Avatar
is working as expected in all cases)Design
label and/or tagged @Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test
steps.@bfitzexpensify looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency
label if this is not an emergency.
Oh boy, what did I do? ๐
Defs not an emergency - label removed.
@rlinoz what did I miss?
Oh apparently not all jobs ran successfully
This is the one that was failing https://github.com/Expensify/App/actions/runs/12958437940/job/36148852073
@jamesdeanexpensify @bfitzexpensify We have to remove this line https://github.com/Expensify/App/blob/aa44d5c3745fb5792eba9ce0cd983ee502111157/docs/redirects.csv#L615 of the redirects.csv
file so we don't have duplicates.
Thanks @rlinoz ! Should I do this in a separate PR?
Yes, please!
Wait did that line.....disappear?
Ah @stitesExpensify fixed it here https://github.com/Expensify/App/pull/55800, thanks! ๐
Amazing, yes thank you!
๐ Deployed to staging by https://github.com/bfitzexpensify in version: 9.0.90-0 ๐
platform | result |
---|---|
๐ค android ๐ค | success โ |
๐ฅ desktop ๐ฅ | success โ |
๐ iOS ๐ | success โ |
๐ธ web ๐ธ | success โ |
๐ค๐ android HybridApp ๐ค๐ | success โ |
๐๐ iOS HybridApp ๐๐ | success โ |
๐ Deployed to production by https://github.com/yuwenmemon in version: 9.0.90-6 ๐
platform | result |
---|---|
๐ค android ๐ค | true โ |
๐ฅ desktop ๐ฅ | success โ |
๐ iOS ๐ | success โ |
๐ธ web ๐ธ | success โ |
๐ค๐ android HybridApp ๐ค๐ | failure โ |
๐๐ iOS HybridApp ๐๐ | success โ |
Redirecting from a broken link
Explanation of Change
Fixed Issues
$ PROPOSAL:
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop