Closed bernhardoj closed 1 week ago
@allgandalf Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]
### Fixed Issues
section aboveTests
sectionQA steps
sectiontoggleReport
and not onIconClick
).src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components using Avatar
have been tested & I retested again)/** comment above it */
this
properly so there are no scoping issues (i.e. for onClick={this.submit}
the method this.submit
should be bound to this
in the constructor)this
are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this);
if this.submit
is never passed to a component event handler like onClick
)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG
)Avatar
is modified, I verified that Avatar
is working as expected in all cases)Design
label and/or tagged @Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test
steps.π Deployed to staging by https://github.com/danieldoglas in version: 9.0.95-0 π
platform | result |
---|---|
π€ android π€ | success β |
π₯ desktop π₯ | success β |
π iOS π | success β |
πΈ web πΈ | success β |
π€π android HybridApp π€π | success β |
ππ iOS HybridApp ππ | success β |
π Deployed to production by https://github.com/Julesssss in version: 9.0.95-6 π
platform | result |
---|---|
π€ android π€ | true β |
π₯ desktop π₯ | success β |
π iOS π | success β |
πΈ web πΈ | success β |
π€π android HybridApp π€π | failure β |
ππ iOS HybridApp ππ | failure β |
Explanation of Change
Fixed Issues
$ https://github.com/Expensify/App/issues/54679 PROPOSAL: https://github.com/Expensify/App/issues/54679
Tests
Same as QA Steps
Offline tests
Same as QA Steps
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
https://github.com/user-attachments/assets/95f389b8-4f6e-4f0e-bed7-4ef2d9696027Android: mWeb Chrome
https://github.com/user-attachments/assets/7cedb169-ae7a-44aa-b762-c8728b27a6f4iOS: Native
https://github.com/user-attachments/assets/1f4605dd-3b55-4694-9ca2-68c93215a04eiOS: mWeb Safari
https://github.com/user-attachments/assets/9514f8d7-1fa5-4122-bf7c-434a5c3516ecMacOS: Chrome / Safari
https://github.com/user-attachments/assets/977c7698-ee04-4f3a-88d9-baf90cdb72a4MacOS: Desktop
https://github.com/user-attachments/assets/ab3837b5-d38b-4320-b74d-92bbb3ea50bd