Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
4.03k stars 3.03k forks source link

Fix read newest action doesn't mark the report as read #55763

Closed bernhardoj closed 1 week ago

bernhardoj commented 3 weeks ago

Explanation of Change

Fixed Issues

$ https://github.com/Expensify/App/issues/54679 PROPOSAL: https://github.com/Expensify/App/issues/54679

Tests

Same as QA Steps

Offline tests

Same as QA Steps

QA Steps

  1. [User A] Open a chat with User B
  2. [User B] Send a message to User A
  3. [User A] Verify the report LHN is not bold (for small screen go back from report to see the LHN)
  4. Try it multiple times

PR Author Checklist

Screenshots/Videos

Android: Native https://github.com/user-attachments/assets/95f389b8-4f6e-4f0e-bed7-4ef2d9696027
Android: mWeb Chrome https://github.com/user-attachments/assets/7cedb169-ae7a-44aa-b762-c8728b27a6f4
iOS: Native https://github.com/user-attachments/assets/1f4605dd-3b55-4694-9ca2-68c93215a04e
iOS: mWeb Safari https://github.com/user-attachments/assets/9514f8d7-1fa5-4122-bf7c-434a5c3516ec
MacOS: Chrome / Safari https://github.com/user-attachments/assets/977c7698-ee04-4f3a-88d9-baf90cdb72a4
MacOS: Desktop https://github.com/user-attachments/assets/ab3837b5-d38b-4320-b74d-92bbb3ea50bd
melvin-bot[bot] commented 3 weeks ago

@allgandalf Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

allgandalf commented 2 weeks ago

Reviewer Checklist

Screenshots/Videos

Android: Native https://github.com/user-attachments/assets/3a54ea52-5e5d-4b55-999a-d7f9f89dd55a
Android: mWeb Chrome https://github.com/user-attachments/assets/58ec129b-bb3b-413d-a67d-978ef60f584b
iOS: Native https://github.com/user-attachments/assets/4adf449e-b1f9-4d0a-be44-a98f953a98b2
iOS: mWeb Safari https://github.com/user-attachments/assets/650ba08f-c9a1-408a-976f-3ec3d2469291
MacOS: Chrome / Safari https://github.com/user-attachments/assets/9b115a78-ecad-4258-b1d5-185c9f763335
MacOS: Desktop https://github.com/user-attachments/assets/4c735c44-0d29-4843-909e-bea21fcb41a5
github-actions[bot] commented 1 week ago

πŸš€ Deployed to staging by https://github.com/danieldoglas in version: 9.0.95-0 πŸš€

platform result
πŸ€– android πŸ€– success βœ…
πŸ–₯ desktop πŸ–₯ success βœ…
🍎 iOS 🍎 success βœ…
πŸ•Έ web πŸ•Έ success βœ…
πŸ€–πŸ”„ android HybridApp πŸ€–πŸ”„ success βœ…
πŸŽπŸ”„ iOS HybridApp πŸŽπŸ”„ success βœ…
github-actions[bot] commented 6 days ago

πŸš€ Deployed to production by https://github.com/Julesssss in version: 9.0.95-6 πŸš€

platform result
πŸ€– android πŸ€– true ❌
πŸ–₯ desktop πŸ–₯ success βœ…
🍎 iOS 🍎 success βœ…
πŸ•Έ web πŸ•Έ success βœ…
πŸ€–πŸ”„ android HybridApp πŸ€–πŸ”„ failure ❌
πŸŽπŸ”„ iOS HybridApp πŸŽπŸ”„ failure ❌