Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
4.03k stars 3.03k forks source link

fix: you've been switched to focus mode modal after open an expense on the Reports page #55764

Closed truph01 closed 2 weeks ago

truph01 commented 2 weeks ago

Explanation of Change

Fixed Issues

$ https://github.com/Expensify/App/issues/55492 PROPOSAL: https://github.com/Expensify/App/issues/55492#issuecomment-2603754755

Tests

  1. Log in to an account and ensure the following conditions are met:
  1. Navigate to the "Reports" tab.

  2. Open the FAB menu and create enough expenses to bring the total number of reports to 30 or more.

  3. Confirm that no "You've been switched to focus mode" modal appears.

  4. Go to the "Inbox" tab.

  5. Verify that the "You've been switched to focus mode" modal is displayed.

Note: To simplify testing this issue, consider updating the MAX_COUNT_BEFORE_FOCUS_UPDATE value in the app to a smaller number. Such as in my record videos, I use MAX_COUNT_BEFORE_FOCUS_UPDATE=4.

Offline tests

QA Steps

  1. Log in to an account and ensure the following conditions are met:
  1. Navigate to the "Reports" tab.

  2. Open the FAB menu and create enough expenses to bring the total number of reports to 30 or more.

  3. Confirm that no "You've been switched to focus mode" modal appears.

  4. Go to the "Inbox" tab.

  5. Verify that the "You've been switched to focus mode" modal is displayed.

Note: To simplify testing this issue, consider updating the MAX_COUNT_BEFORE_FOCUS_UPDATE value in the app to a smaller number.

PR Author Checklist

Screenshots/Videos

Android: Native https://github.com/user-attachments/assets/f939f19d-53eb-4ba5-80c2-4f10e2fe2afa
Android: mWeb Chrome https://github.com/user-attachments/assets/5fa68cb3-a703-447e-86a9-1aa50d7c4e4c
iOS: Native https://github.com/user-attachments/assets/cdc942f9-5116-4fdf-8a76-430bc94e8b4f
iOS: mWeb Safari https://github.com/user-attachments/assets/89efd919-5eaf-4a95-b058-bf7146c70cf1
MacOS: Chrome / Safari https://github.com/user-attachments/assets/8b109186-0378-4e1e-8cd4-fd9a97ac7dd4
MacOS: Desktop https://github.com/user-attachments/assets/5a113096-7524-41ef-bf04-ad90358ace38
melvin-bot[bot] commented 2 weeks ago

@dukenv0307 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

dukenv0307 commented 2 weeks ago

Reviewer Checklist

Screenshots/Videos

Android: Native https://github.com/user-attachments/assets/28045904-2722-42ad-88fd-00b7675547aa
Android: mWeb Chrome https://github.com/user-attachments/assets/d6e8630a-460f-49e0-85af-cf2290f94f5c
iOS: Native https://github.com/user-attachments/assets/b2ad4da1-3301-4047-b3e4-d3d8384a0bad
iOS: mWeb Safari https://github.com/user-attachments/assets/4e588234-0010-464d-a564-23db15b9b3da
MacOS: Chrome / Safari https://github.com/user-attachments/assets/0b2081c5-b155-40de-bcb6-0ec67bde7856
MacOS: Desktop https://github.com/user-attachments/assets/0caf8820-9db9-4ca7-9ef4-0254fcfab8c3
OSBotify commented 2 weeks ago

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

kavimuru commented 2 weeks ago

@dukenv0307 @iwiznia How do we set up -The nvp_priorityMode setting is set to false.

github-actions[bot] commented 2 weeks ago

πŸš€ Deployed to staging by https://github.com/iwiznia in version: 9.0.90-0 πŸš€

platform result
πŸ€– android πŸ€– success βœ…
πŸ–₯ desktop πŸ–₯ success βœ…
🍎 iOS 🍎 success βœ…
πŸ•Έ web πŸ•Έ success βœ…
πŸ€–πŸ”„ android HybridApp πŸ€–πŸ”„ success βœ…
πŸŽπŸ”„ iOS HybridApp πŸŽπŸ”„ success βœ…
iwiznia commented 2 weeks ago

Not sure, @truph01 can you help out QA to test this PR.

github-actions[bot] commented 2 weeks ago

πŸš€ Deployed to production by https://github.com/yuwenmemon in version: 9.0.90-6 πŸš€

platform result
πŸ€– android πŸ€– true ❌
πŸ–₯ desktop πŸ–₯ success βœ…
🍎 iOS 🍎 success βœ…
πŸ•Έ web πŸ•Έ success βœ…
πŸ€–πŸ”„ android HybridApp πŸ€–πŸ”„ failure ❌
πŸŽπŸ”„ iOS HybridApp πŸŽπŸ”„ success βœ