Closed truph01 closed 2 weeks ago
@dukenv0307 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]
### Fixed Issues
section aboveTests
sectionQA steps
sectiontoggleReport
and not onIconClick
).myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components using Avatar
have been tested & I retested again)/** comment above it */
this
properly so there are no scoping issues (i.e. for onClick={this.submit}
the method this.submit
should be bound to this
in the constructor)this
are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this);
if this.submit
is never passed to a component event handler like onClick
)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG
)Avatar
is modified, I verified that Avatar
is working as expected in all cases)Design
label and/or tagged @Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test
steps.:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.
@dukenv0307 @iwiznia How do we set up -The nvp_priorityMode setting is set to false.
π Deployed to staging by https://github.com/iwiznia in version: 9.0.90-0 π
platform | result |
---|---|
π€ android π€ | success β |
π₯ desktop π₯ | success β |
π iOS π | success β |
πΈ web πΈ | success β |
π€π android HybridApp π€π | success β |
ππ iOS HybridApp ππ | success β |
Not sure, @truph01 can you help out QA to test this PR.
π Deployed to production by https://github.com/yuwenmemon in version: 9.0.90-6 π
platform | result |
---|---|
π€ android π€ | true β |
π₯ desktop π₯ | success β |
π iOS π | success β |
πΈ web πΈ | success β |
π€π android HybridApp π€π | failure β |
ππ iOS HybridApp ππ | success β |
Explanation of Change
Fixed Issues
$ https://github.com/Expensify/App/issues/55492 PROPOSAL: https://github.com/Expensify/App/issues/55492#issuecomment-2603754755
Tests
nvp_priorityMode
setting is set to false.Navigate to the "Reports" tab.
Open the FAB menu and create enough expenses to bring the total number of reports to 30 or more.
Confirm that no "You've been switched to focus mode" modal appears.
Go to the "Inbox" tab.
Verify that the "You've been switched to focus mode" modal is displayed.
Note: To simplify testing this issue, consider updating the MAX_COUNT_BEFORE_FOCUS_UPDATE value in the app to a smaller number. Such as in my record videos, I use
MAX_COUNT_BEFORE_FOCUS_UPDATE=4
.Offline tests
QA Steps
nvp_priorityMode
setting is set to false.Navigate to the "Reports" tab.
Open the FAB menu and create enough expenses to bring the total number of reports to 30 or more.
Confirm that no "You've been switched to focus mode" modal appears.
Go to the "Inbox" tab.
Verify that the "You've been switched to focus mode" modal is displayed.
Note: To simplify testing this issue, consider updating the MAX_COUNT_BEFORE_FOCUS_UPDATE value in the app to a smaller number.
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
https://github.com/user-attachments/assets/f939f19d-53eb-4ba5-80c2-4f10e2fe2afaAndroid: mWeb Chrome
https://github.com/user-attachments/assets/5fa68cb3-a703-447e-86a9-1aa50d7c4e4ciOS: Native
https://github.com/user-attachments/assets/cdc942f9-5116-4fdf-8a76-430bc94e8b4fiOS: mWeb Safari
https://github.com/user-attachments/assets/89efd919-5eaf-4a95-b058-bf7146c70cf1MacOS: Chrome / Safari
https://github.com/user-attachments/assets/8b109186-0378-4e1e-8cd4-fd9a97ac7dd4MacOS: Desktop
https://github.com/user-attachments/assets/5a113096-7524-41ef-bf04-ad90358ace38