Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
4.03k stars 3.03k forks source link

Report isn't showing most recent chats until refreshed #55765

Closed mohit6789 closed 1 week ago

mohit6789 commented 2 weeks ago

Explanation of Change

Fixed Issues

$https://github.com/Expensify/App/issues/54785 PROPOSAL:https://github.com/Expensify/App/issues/54785#issuecomment-2587656243

Tests

Same as QA

Offline tests

NA

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

  1. Navigate to the "Reports" section.
  2. Check for recent chats.
  3. Make sure you have more than 50 chats in "All chats".
  4. Scroll down to the end of the "All Chat" Section".
  5. Now scroll up to top of the page.
  6. Send message from another tab.
  7. Expected: Most recent message should be shown in few moment.

PR Author Checklist

Screenshots/Videos

Android: Native https://github.com/user-attachments/assets/3b6bfba3-1145-494c-a1b5-9b009ad42abd
Android: mWeb Chrome https://github.com/user-attachments/assets/831386c2-01b2-497d-8001-8618b777c6d7
iOS: Native https://github.com/user-attachments/assets/8837b86a-89d9-4490-897f-b2d60b61a211
iOS: mWeb Safari https://github.com/user-attachments/assets/edba1925-cc75-410c-b873-4935b6dd82b3
MacOS: Chrome / Safari https://github.com/user-attachments/assets/0105b02c-811d-43d4-a110-ceb02f94981e
MacOS: Desktop https://github.com/user-attachments/assets/bcb660f4-c047-403b-969f-2e1ac1bbdba3
melvin-bot[bot] commented 2 weeks ago

@allroundexperts Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

allroundexperts commented 2 weeks ago

Reviewer Checklist

Screenshots/Videos

Android: Native Error building on Android
Android: mWeb Chrome https://github.com/user-attachments/assets/23152b9e-4684-43d6-bde8-8cd9b7208360
iOS: Native https://github.com/user-attachments/assets/9143f4dd-0473-4d1a-b0e9-81dc6947d119
iOS: mWeb Safari https://github.com/user-attachments/assets/5b058e46-39d0-41aa-b06f-35f9f3beb086
MacOS: Chrome / Safari https://github.com/user-attachments/assets/eac532cf-e262-4bc8-b87b-23e0e32a3a65
MacOS: Desktop https://github.com/user-attachments/assets/2baa8211-9754-49b2-b21c-7b0b1c27c7fc
mohit6789 commented 1 week ago

@francoisl can you please review this PR? Thanks

francoisl commented 1 week ago

LGTM, can you fix the conflicts please, and I'll merge ASAP

mohit6789 commented 1 week ago

@francoisl Conflict resolved.

OSBotify commented 1 week ago

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions[bot] commented 1 week ago

🚀 Deployed to staging by https://github.com/francoisl in version: 9.0.95-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅
🤖🔄 android HybridApp 🤖🔄 success ✅
🍎🔄 iOS HybridApp 🍎🔄 success ✅
github-actions[bot] commented 3 days ago

🚀 Deployed to production by https://github.com/Julesssss in version: 9.0.95-6 🚀

platform result
🤖 android 🤖 true ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅
🤖🔄 android HybridApp 🤖🔄 failure ❌
🍎🔄 iOS HybridApp 🍎🔄 failure ❌