Closed mohit6789 closed 1 week ago
@allroundexperts Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]
### Fixed Issues
section aboveTests
sectionQA steps
sectiontoggleReport
and not onIconClick
).src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components using Avatar
have been tested & I retested again)/** comment above it */
this
properly so there are no scoping issues (i.e. for onClick={this.submit}
the method this.submit
should be bound to this
in the constructor)this
are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this);
if this.submit
is never passed to a component event handler like onClick
)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG
)Avatar
is modified, I verified that Avatar
is working as expected in all cases)Design
label and/or tagged @Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test
steps.@francoisl can you please review this PR? Thanks
LGTM, can you fix the conflicts please, and I'll merge ASAP
@francoisl Conflict resolved.
:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.
🚀 Deployed to staging by https://github.com/francoisl in version: 9.0.95-0 🚀
platform | result |
---|---|
🤖 android 🤖 | success ✅ |
🖥 desktop 🖥 | success ✅ |
🍎 iOS 🍎 | success ✅ |
🕸 web 🕸 | success ✅ |
🤖🔄 android HybridApp 🤖🔄 | success ✅ |
🍎🔄 iOS HybridApp 🍎🔄 | success ✅ |
🚀 Deployed to production by https://github.com/Julesssss in version: 9.0.95-6 🚀
platform | result |
---|---|
🤖 android 🤖 | true ❌ |
🖥 desktop 🖥 | success ✅ |
🍎 iOS 🍎 | success ✅ |
🕸 web 🕸 | success ✅ |
🤖🔄 android HybridApp 🤖🔄 | failure ❌ |
🍎🔄 iOS HybridApp 🍎🔄 | failure ❌ |
Explanation of Change
Fixed Issues
$https://github.com/Expensify/App/issues/54785 PROPOSAL:https://github.com/Expensify/App/issues/54785#issuecomment-2587656243
Tests
Same as QA
Offline tests
NA
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
https://github.com/user-attachments/assets/3b6bfba3-1145-494c-a1b5-9b009ad42abdAndroid: mWeb Chrome
https://github.com/user-attachments/assets/831386c2-01b2-497d-8001-8618b777c6d7iOS: Native
https://github.com/user-attachments/assets/8837b86a-89d9-4490-897f-b2d60b61a211iOS: mWeb Safari
https://github.com/user-attachments/assets/edba1925-cc75-410c-b873-4935b6dd82b3MacOS: Chrome / Safari
https://github.com/user-attachments/assets/0105b02c-811d-43d4-a110-ceb02f94981eMacOS: Desktop
https://github.com/user-attachments/assets/bcb660f4-c047-403b-969f-2e1ac1bbdba3