Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
4.02k stars 3.01k forks source link

fix - Expensify Card - Back button on Not so fast page closes RHP instead of returning to profile page #56352

Open FitseTLT opened 5 days ago

FitseTLT commented 5 days ago

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/55720 PROPOSAL: https://github.com/Expensify/App/issues/55720#issuecomment-2612611723

Tests

Precondition:

User A has a workspace with Expensify Card enabled. The workspace has at least one Expensify card. User B has "Limited" access (copilot) to User A account.

  1. Log in as User B.
  2. Go to Account settings.
  3. Click on the account switcher.
  4. Select User A.
  5. Go to workspace settings > Members.
  6. Click on any member.
  7. Click + New card.
  8. Click RHP back button.
  9. Verify RHP will return to the previous page which is the member profile page.

Offline tests

Same as above

QA Steps

Same as above

PR Author Checklist

Screenshots/Videos

Android: Native https://github.com/user-attachments/assets/e0fa0589-e4f2-4fd0-83d8-12a9af415d39
Android: mWeb Chrome https://github.com/user-attachments/assets/06df4d80-0207-4a79-897e-c8ae31e34c20
iOS: Native https://github.com/user-attachments/assets/ae827904-2eaa-4a95-94e4-0f882fce7338
iOS: mWeb Safari https://github.com/user-attachments/assets/de3856c1-b4b1-430c-8d3b-7fe4573681ac
MacOS: Chrome / Safari https://github.com/user-attachments/assets/f995d937-390d-4239-804f-954292050d3a
MacOS: Desktop https://github.com/user-attachments/assets/7b6f6777-92c9-4088-922f-e351eaedf07b
melvin-bot[bot] commented 5 days ago

@allroundexperts Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]