Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
4.03k stars 3.03k forks source link

Android - Attachment - App crashes when take photo #56354

Closed vincdargento closed 1 week ago

vincdargento commented 1 week ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.94-1 Reproducible in staging?: Yes Reproducible in production?: No If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: No, reproducible on hybrid only If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5560481&group_by=cases:section_id&group_order=asc&group_id=292107 Email or phone of affected tester (no customers): gocemate+b1916@gmail.com Issue reported by: Applause Internal Team Device used: Samsung Galaxy A02s/12 App Component: Other

Action Performed:

  1. Go to any chat
  2. Tap + > Add attachment> Take photo
  3. Tap OK

Expected Result:

Photo attachment should be uploaded to the chat and there should be no crash

Actual Result:

App crashes when try to send taken photo as attachment

Workaround:

Unknown

Platforms:

Screenshots/Videos

https://github.com/user-attachments/assets/6b5363e6-3004-4e75-8ddb-48f3815c3fad

View all open jobs on GitHub

melvin-bot[bot] commented 1 week ago

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

melvin-bot[bot] commented 1 week ago

Triggered auto assignment to @mjasikowski (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

melvin-bot[bot] commented 1 week ago

💬 A slack conversation has been started in #expensify-open-source

github-actions[bot] commented 1 week ago

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.
vincdargento commented 1 week ago

@jliexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

roryabraham commented 1 week ago

I can take this over from @mjasikowski

roryabraham commented 1 week ago

Mobile-Expensify PR merged. It will be deployed next time we do an E/App CP (should be soon)

roryabraham commented 1 week ago

This should be fixed. Requested retest

mvtglobally commented 1 week ago

not repro

https://github.com/user-attachments/assets/8b64e546-cfcd-4eff-821b-8a2644dd9535

roryabraham commented 1 week ago

This is fixed