Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
4.03k stars 3.03k forks source link

[$250] Onboarding - FAB button does not change shape when opening FAB from task description #56356

Closed vincdargento closed 1 week ago

vincdargento commented 1 week ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue was found while executing QA for PR #55222

Version Number: v9.0.94-1 Reproducible in staging?: Yes Reproducible in production?: No If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A If this was caught during regression testing, add the test name, ID and link from TestRail: https://github.com/Expensify/App/pull/55222 Email or phone of affected tester (no customers): dave0123seife@gmail.com Issue reported by: Applause Internal Team Device used: Mac 14.5/ Chrome App Component: Other

Action Performed:

  1. Go to https://staging.new.expensify.com
  2. Create new account
  3. Choose "Get paid back by my employer" option in onboarding
  4. Click the "Submit expense" task from Concierge
  5. Click on the green emoji-like button

Expected Result:

FAB is opened and FAB Button shape changes indicating that it is opened and clicking on it closes the FAB.

Actual Result:

FAB Button shape does not change while the FAB menu is opened. And clicking on it does not close the FAB but opens it again.

Workaround:

Unknown

Platforms:

Screenshots/Videos

https://github.com/user-attachments/assets/1d7d0595-578e-401e-8e00-74840c618ba3

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021886808048260636387
  • Upwork Job ID: 1886808048260636387
  • Last Price Increase: 2025-02-04
Issue OwnerCurrent Issue Owner: @allgandalf
melvin-bot[bot] commented 1 week ago

Triggered auto assignment to @VictoriaExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

melvin-bot[bot] commented 1 week ago

Triggered auto assignment to @madmax330 (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

melvin-bot[bot] commented 1 week ago

💬 A slack conversation has been started in #expensify-open-source

github-actions[bot] commented 1 week ago

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.
vincdargento commented 1 week ago

@VictoriaExpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

melvin-bot[bot] commented 1 week ago

Job added to Upwork: https://www.upwork.com/jobs/~021886808048260636387

melvin-bot[bot] commented 1 week ago

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allgandalf (External)

mvtglobally commented 1 week ago

Fixed https://github.com/user-attachments/assets/9bf931f6-e982-41a4-8164-1cd97a598e79