Closed roryabraham closed 1 week ago
@akinwale Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]
@akinwale no C+ review needed here.
@blimpich requesting your review since you're the only Expensify engineer I see in the blame
:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.
š Deployed to staging by https://github.com/blimpich in version: 9.0.95-0 š
platform | result |
---|---|
š¤ android š¤ | success ā |
š„ desktop š„ | success ā |
š iOS š | success ā |
šø web šø | success ā |
š¤š android HybridApp š¤š | success ā |
šš iOS HybridApp šš | success ā |
š Deployed to production by https://github.com/Julesssss in version: 9.0.95-6 š
platform | result |
---|---|
š¤ android š¤ | true ā |
š„ desktop š„ | success ā |
š iOS š | success ā |
šø web šø | success ā |
š¤š android HybridApp š¤š | failure ā |
šš iOS HybridApp šš | failure ā |
Explanation of Change
Reducing GH noise when there are workflow failures after code is merged to main.
Fixed Issues
$ https://github.com/Expensify/App/issues/56292
Tests
Tested similar code locally:
Offline tests
n/a
QA Steps
None.
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop