Closed nkdengineer closed 4 days ago
@dukenv0307 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]
### Fixed Issues
section aboveTests
sectionQA steps
sectiontoggleReport
and not onIconClick
).myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components using Avatar
have been tested & I retested again)/** comment above it */
this
properly so there are no scoping issues (i.e. for onClick={this.submit}
the method this.submit
should be bound to this
in the constructor)this
are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this);
if this.submit
is never passed to a component event handler like onClick
)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG
)Avatar
is modified, I verified that Avatar
is working as expected in all cases)Design
label and/or tagged @Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test
steps.:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.
π Deployed to staging by https://github.com/arosiclair in version: 9.0.95-0 π
platform | result |
---|---|
π€ android π€ | success β |
π₯ desktop π₯ | success β |
π iOS π | success β |
πΈ web πΈ | success β |
π€π android HybridApp π€π | success β |
ππ iOS HybridApp ππ | success β |
Explanation of Change
fix: per diem options disappears after changing currency offline
Fixed Issues
$ https://github.com/Expensify/App/issues/56071 PROPOSAL: https://github.com/Expensify/App/issues/56071#issuecomment-2630025872
Tests
Precondition: The account only has one group workspace with the per diem feature enabled
Offline tests
Same
QA Steps
Precondition: The account only has one group workspace with the per diem feature enabled
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
https://github.com/user-attachments/assets/2a880001-c941-4782-a801-4f711aacbd24Android: mWeb Chrome
https://github.com/user-attachments/assets/0844bfcb-6526-4ab7-8e31-f7045fe00937iOS: Native
https://github.com/user-attachments/assets/175559cb-53f7-42e9-bf24-6306e50a89abiOS: mWeb Safari
https://github.com/user-attachments/assets/5f733059-2216-47e9-a0c7-d713c8548076MacOS: Chrome / Safari
https://github.com/user-attachments/assets/bbc853ae-f81e-4bd6-a765-6ffcdf93ce05MacOS: Desktop
https://github.com/user-attachments/assets/c56f997e-a97f-4f2a-ba4e-ce60bfcb65c6