Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
4.02k stars 3.01k forks source link

fix: per diem options disappears after changing currency offline #56359

Closed nkdengineer closed 4 days ago

nkdengineer commented 5 days ago

Explanation of Change

fix: per diem options disappears after changing currency offline

Fixed Issues

$ https://github.com/Expensify/App/issues/56071 PROPOSAL: https://github.com/Expensify/App/issues/56071#issuecomment-2630025872

Tests

Precondition: The account only has one group workspace with the per diem feature enabled

  1. Go offline
  2. Go to the workspace overview
  3. Change the currency
  4. Go FAB > Create expense
  5. Verify that the per diem option still appears
    • [x] Verify that no errors appear in the JS console

Offline tests

Same

QA Steps

Precondition: The account only has one group workspace with the per diem feature enabled

  1. Go offline
  2. Go to the workspace overview
  3. Change the currency
  4. Go FAB > Create expense
  5. Verify that the per diem option still appears
    • [x] Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native https://github.com/user-attachments/assets/2a880001-c941-4782-a801-4f711aacbd24
Android: mWeb Chrome https://github.com/user-attachments/assets/0844bfcb-6526-4ab7-8e31-f7045fe00937
iOS: Native https://github.com/user-attachments/assets/175559cb-53f7-42e9-bf24-6306e50a89ab
iOS: mWeb Safari https://github.com/user-attachments/assets/5f733059-2216-47e9-a0c7-d713c8548076
MacOS: Chrome / Safari https://github.com/user-attachments/assets/bbc853ae-f81e-4bd6-a765-6ffcdf93ce05
MacOS: Desktop https://github.com/user-attachments/assets/c56f997e-a97f-4f2a-ba4e-ce60bfcb65c6
melvin-bot[bot] commented 5 days ago

@dukenv0307 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

dukenv0307 commented 5 days ago

Reviewer Checklist

Screenshots/Videos

Android: Native https://github.com/user-attachments/assets/fd988b7b-40f4-4cea-b42b-046076293496
Android: mWeb Chrome https://github.com/user-attachments/assets/cac0cc71-a242-42dc-ae5d-335188eeafc7
iOS: Native https://github.com/user-attachments/assets/40ab9616-3da2-4c57-8174-d3ee827060d1
iOS: mWeb Safari https://github.com/user-attachments/assets/d8124b3b-f31e-4a18-9f56-455506c88311
MacOS: Chrome / Safari https://github.com/user-attachments/assets/8296bb76-abb9-4e22-a40f-eefd3978968a
MacOS: Desktop https://github.com/user-attachments/assets/f23eb211-7831-4e8e-afe4-033e8595b1d1
OSBotify commented 4 days ago

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions[bot] commented 3 days ago

πŸš€ Deployed to staging by https://github.com/arosiclair in version: 9.0.95-0 πŸš€

platform result
πŸ€– android πŸ€– success βœ…
πŸ–₯ desktop πŸ–₯ success βœ…
🍎 iOS 🍎 success βœ…
πŸ•Έ web πŸ•Έ success βœ…
πŸ€–πŸ”„ android HybridApp πŸ€–πŸ”„ success βœ…
πŸŽπŸ”„ iOS HybridApp πŸŽπŸ”„ success βœ