Closed roryabraham closed 5 days ago
Weird, didn't get the option to add a reviewer checklist so I went ahead and approved. Once the author's checklist is also complete maybe it gives me the option to add my checklist and review again?
was assigned as C+ for the blocker https://github.com/Expensify/App/issues/56356#issuecomment-2634415616, does the revert need a C+ review?
@allgandalf Straight revert so no review here
straight revert, merging w/o checklists
@roryabraham looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency
label if this is not an emergency.
:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.
🚀 Cherry-picked to staging by https://github.com/roryabraham in version: 9.0.94-4 🚀
platform | result |
---|---|
🤖 android 🤖 | cancelled 🔪 |
🖥 desktop 🖥 | cancelled 🔪 |
🍎 iOS 🍎 | cancelled 🔪 |
🕸 web 🕸 | success ✅ |
🤖🔄 android HybridApp 🤖🔄 | failure ❌ |
🍎🔄 iOS HybridApp 🍎🔄 | failure ❌ |
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.
🚀 Deployed to production by https://github.com/AndrewGable in version: 9.0.94-25 🚀
platform | result |
---|---|
🤖 android 🤖 | true ❌ |
🖥 desktop 🖥 | cancelled 🔪 |
🍎 iOS 🍎 | success ✅ |
🕸 web 🕸 | success ✅ |
🤖🔄 android HybridApp 🤖🔄 | failure ❌ |
🍎🔄 iOS HybridApp 🍎🔄 | failure ❌ |
🚀 Deployed to production by https://github.com/AndrewGable in version: 9.0.94-25 🚀
platform | result |
---|---|
🤖 android 🤖 | true ❌ |
🖥 desktop 🖥 | success ✅ |
🍎 iOS 🍎 | success ✅ |
🕸 web 🕸 | success ✅ |
🤖🔄 android HybridApp 🤖🔄 | failure ❌ |
🍎🔄 iOS HybridApp 🍎🔄 | failure ❌ |
Reverts Expensify/App#55222
Fixes