Closed kubabutkiewicz closed 5 days ago
@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]
### Fixed Issues
section aboveTests
sectionQA steps
sectiontoggleReport
and not onIconClick
).myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components using Avatar
have been tested & I retested again)/** comment above it */
this
properly so there are no scoping issues (i.e. for onClick={this.submit}
the method this.submit
should be bound to this
in the constructor)this
are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this);
if this.submit
is never passed to a component event handler like onClick
)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG
)Avatar
is modified, I verified that Avatar
is working as expected in all cases)Design
label and/or tagged @Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test
steps.@grgia All yours
:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.
@kubabutkiewicz @grgia Is applause.expensifail.com domain is added to beta newDotManagerMcTest?
π Deployed to staging by https://github.com/grgia in version: 9.0.97-0 π
platform | result |
---|---|
π€ android π€ | success β |
π₯ desktop π₯ | success β |
π iOS π | success β |
πΈ web πΈ | success β |
π€π android HybridApp π€π | success β |
ππ iOS HybridApp ππ | success β |
@kubabutkiewicz @grgia Is applause.expensifail.com domain is added to beta newDotManagerMcTest?
Hi @m-natarajan, I have just added the domain to the beta. It might take a short while.
@grgia @DylanDylann QA steps weren't filled out:
// TODO: These must be filled out, or the issue title must include "[No QA]." Same as tests
π Deployed to production by https://github.com/Julesssss in version: 9.0.97-1 π
platform | result |
---|---|
π€ android π€ | true β |
π₯ desktop π₯ | success β |
π iOS π | success β |
πΈ web πΈ | success β |
π€π android HybridApp π€π | failure β |
ππ iOS HybridApp ππ | failure β |
Explanation of Change
Fixed Issues
$ https://github.com/Expensify/App/issues/55006 PROPOSAL:
Tests
Make sure that your account is added to beta
newDotManagerMcTest
Login to app with account that didn't submit expense or scan a receipt
Go to FAB and select Create Expense
Select a receipt
Verify that Manager McTest is visible as a recipient
Login to app with account
Go to FAB and select Start Chat
Verify that Manager McTest isn't visible as a recipient
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]." Same as tests
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop