Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
4.03k stars 3.03k forks source link

Show Manager McTest as recipient for eligible users #56364

Closed kubabutkiewicz closed 5 days ago

kubabutkiewicz commented 1 week ago

Explanation of Change

Fixed Issues

$ https://github.com/Expensify/App/issues/55006 PROPOSAL:

Tests

Make sure that your account is added to beta newDotManagerMcTest

  1. Login to app with account that didn't submit expense or scan a receipt

  2. Go to FAB and select Create Expense

  3. Select a receipt

  4. Verify that Manager McTest is visible as a recipient

  5. Login to app with account

  6. Go to FAB and select Start Chat

  7. Verify that Manager McTest isn't visible as a recipient

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]." Same as tests

PR Author Checklist

Screenshots/Videos

Android: Native android
Android: mWeb Chrome
iOS: Native ios
iOS: mWeb Safari
MacOS: Chrome / Safari web
MacOS: Desktop desktop
melvin-bot[bot] commented 1 week ago

@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

DylanDylann commented 1 week ago

Reviewer Checklist

Screenshots/Videos

Android: Native https://github.com/user-attachments/assets/8d431d48-524f-4bfd-9b12-008106592459
Android: mWeb Chrome https://github.com/user-attachments/assets/4ee39851-6e19-47ca-8845-59b7c52679e4
iOS: Native https://github.com/user-attachments/assets/1d3dc0bb-4053-4cd5-8cb6-e923fded406a
iOS: mWeb Safari https://github.com/user-attachments/assets/de62c595-4b33-4781-8e4c-df4e027809b7
MacOS: Chrome / Safari https://github.com/user-attachments/assets/9dd3b441-df01-42a8-bbe4-ec46d7577cee
MacOS: Desktop https://github.com/user-attachments/assets/9b378c2b-1848-48ba-932e-4f2a57b28531
DylanDylann commented 6 days ago

@grgia All yours

OSBotify commented 5 days ago

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

m-natarajan commented 5 days ago

@kubabutkiewicz @grgia Is applause.expensifail.com domain is added to beta newDotManagerMcTest?

github-actions[bot] commented 5 days ago

πŸš€ Deployed to staging by https://github.com/grgia in version: 9.0.97-0 πŸš€

platform result
πŸ€– android πŸ€– success βœ…
πŸ–₯ desktop πŸ–₯ success βœ…
🍎 iOS 🍎 success βœ…
πŸ•Έ web πŸ•Έ success βœ…
πŸ€–πŸ”„ android HybridApp πŸ€–πŸ”„ success βœ…
πŸŽπŸ”„ iOS HybridApp πŸŽπŸ”„ success βœ…
Julesssss commented 4 days ago

@kubabutkiewicz @grgia Is applause.expensifail.com domain is added to beta newDotManagerMcTest?

Hi @m-natarajan, I have just added the domain to the beta. It might take a short while.

Julesssss commented 4 days ago

@grgia @DylanDylann QA steps weren't filled out:

// TODO: These must be filled out, or the issue title must include "[No QA]." Same as tests

github-actions[bot] commented 4 days ago

πŸš€ Deployed to production by https://github.com/Julesssss in version: 9.0.97-1 πŸš€

platform result
πŸ€– android πŸ€– true ❌
πŸ–₯ desktop πŸ–₯ success βœ…
🍎 iOS 🍎 success βœ…
πŸ•Έ web πŸ•Έ success βœ…
πŸ€–πŸ”„ android HybridApp πŸ€–πŸ”„ failure ❌
πŸŽπŸ”„ iOS HybridApp πŸŽπŸ”„ failure ❌