Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
4.02k stars 3.01k forks source link

[$250] "Company Cards: 'Allow Deleting Transactions' Toggle Not Functioning Correctly, Dependent on 'Delay Submissions' Setting" #56366

Open m-natarajan opened 5 days ago

m-natarajan commented 5 days ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: Reproducible in staging?: Blocked from reproduction Reproducible in production?: Blocked from reproduction If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @joekaufmanexpensify Slack conversation (hyperlinked to channel name): Convert

Action Performed:

  1. Create new workspace.
  2. Enable delay submissions.
  3. Add new direct card feed.
  4. Verify allow deleting transactions is disabled.
  5. Assign a card with expenses.
  6. Go to the workspace chat and verify you're able to delete card expenses (which you shouldn't be able to).
  7. Unassign the card (which removes the expenses).
  8. Disable delay submissions.
  9. Enable allow deleting transactions.
  10. Assign a card with expenses.
  11. Go to the workspace chat and verify you can't delete the card expenses.

Expected Result:

The "Allow Deleting Transactions" toggle should control whether card expenses can be deleted, independent of the "Delay Submissions" setting.

Actual Result:

The ability to delete card expenses is incorrectly dependent on the "Delay Submissions" setting.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Able to delete transactions with delay submissions enabled and allow deleting transactions disabled

https://github.com/user-attachments/assets/fa467d89-1297-4fd3-a252-1088fe036089

Not able to delete transactions with delay submissions disabled and allow deleting transactions enabled.

https://github.com/user-attachments/assets/e70bf588-03c7-42ea-ba61-e23b0fd52ba5

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021887264422295401629
  • Upwork Job ID: 1887264422295401629
  • Last Price Increase: 2025-02-05
Issue OwnerCurrent Issue Owner: @ntdiary
melvin-bot[bot] commented 5 days ago

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

nkuoch commented 4 days ago

@joekaufmanexpensify So, based on https://expensify.slack.com/archives/C07HPDRELLD/p1738705541498639?thread_ts=1738689737.990249&cid=C07HPDRELLD, what should we do? Is it a front-end fix?

joekaufmanexpensify commented 4 days ago

Left a summary of where i think we landed here. LMK what you think!

melvin-bot[bot] commented 4 days ago

Job added to Upwork: https://www.upwork.com/jobs/~021887264422295401629

melvin-bot[bot] commented 4 days ago

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ntdiary (External)