Open MitchExpensify opened 1 week ago
Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 (External
)
Triggered auto assignment to @NicMendonca (NewFeature
), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.
:warning: It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time :warning:
Triggered auto assignment to Design team member for new feature review - @dubielzyk-expensify (NewFeature
)
I don't think this change requires design because its using 100% existing components
🚨 Edited by proposal-police: This proposal was edited at 2025-02-04 18:26:51 UTC.
Set "Delayed submission" to "Manually" by default on new Workspaces
Feature request
Update the following: https://github.com/Expensify/App/blob/96af045d4b4a601cae0feb1229020c2ba7673273/src/libs/actions/Policy/Policy.ts#L1768-L1772
to
autoReportingFrequency: CONST.POLICY.AUTO_REPORTING_FREQUENCIES.IMMEDIATE, / MANUAL (not sure about this value, will discuss more during PR phase, it's most probably immediate as seen in `SetWorkspaceAutoReportingFrequency`)
approvalMode: CONST.POLICY.APPROVAL_MODE.OPTIONAL,
harvesting: {
enabled: false,
},
Make the same in the below cases too:
https://github.com/Expensify/App/blob/96af045d4b4a601cae0feb1229020c2ba7673273/src/libs/actions/Policy/Policy.ts#L2097-L2101 https://github.com/Expensify/App/blob/96af045d4b4a601cae0feb1229020c2ba7673273/src/libs/actions/Policy/Policy.ts#L1678 https://github.com/Expensify/App/blob/96af045d4b4a601cae0feb1229020c2ba7673273/src/libs/actions/Policy/Policy.ts#L1688-L1690 There might be some existing unit tests which will fail once we make these changes so we need to update those too
We also need BE
changes here to match the optimistic data
We can create a policy using onyx data and either write a unit test or a UI test for workflows screen to see if the toggle for delayed submit is on and the submission frequency is set to manually
⚠️ @twilight2294 Thanks for your proposal. Please update it to follow the proposal template, as proposals are only reviewed if they follow that format (note the mandatory sections).
i'll take care of the backend changes needed for this one
@dangrous can you review my proposal here? I guess it's complete as is and matches the expected result
Set "Delayed submission" to "Manually" by default on new Workspaces
Improvement
createDraftInitialWorkspace
, buildPolicyData
, createDraftWorkspace
, and createWorkspaceFromIOUPayment
, we need to update autoReportingFrequency
value from CONST.POLICY.AUTO_REPORTING_FREQUENCIES.INSTANT
to CONST.POLICY.AUTO_REPORTING_FREQUENCIES.IMMEDIATE
and harvesting
's enabled property to false.
https://github.com/Expensify/App/blob/6329bf67de3a40116c88b2e4413fd344d1b3e314/src/libs/actions/Policy/Policy.ts#L1678
https://github.com/Expensify/App/blob/6329bf67de3a40116c88b2e4413fd344d1b3e314/src/libs/actions/Policy/Policy.ts#L1688-L1690
https://github.com/Expensify/App/blob/6329bf67de3a40116c88b2e4413fd344d1b3e314/src/libs/actions/Policy/Policy.ts#L1768
https://github.com/Expensify/App/blob/6329bf67de3a40116c88b2e4413fd344d1b3e314/src/libs/actions/Policy/Policy.ts#L1770-L1772
https://github.com/Expensify/App/blob/6329bf67de3a40116c88b2e4413fd344d1b3e314/src/libs/actions/Policy/Policy.ts#L2097
https://github.com/Expensify/App/blob/6329bf67de3a40116c88b2e4413fd344d1b3e314/src/libs/actions/Policy/Policy.ts#L2099-L2101
https://github.com/Expensify/App/blob/6329bf67de3a40116c88b2e4413fd344d1b3e314/src/libs/actions/Policy/Policy.ts#L2410
https://github.com/Expensify/App/blob/6329bf67de3a40116c88b2e4413fd344d1b3e314/src/libs/actions/Policy/Policy.ts#L2412-L2414setWorkspaceAutoReportingFrequency
inside WorkspaceWorkflowsPage
, we need to pass CONST.POLICY.AUTO_REPORTING_FREQUENCIES.IMMEDIATE
instead of CONST.POLICY.AUTO_REPORTING_FREQUENCIES.WEEKLY
https://github.com/Expensify/App/blob/386ea3e4abed12484ed7a2d9a2fe574d967a3891/src/pages/workspace/workflows/WorkspaceWorkflowsPage.tsx#L136-L141areWorkflowsEnabled
value to true
when creating onyx data for a new workspace.
Backend PR is in review!
@abdulrahuman5196 can you please review my proposal here
~@MitchExpensify Could you kindly re-assign this to different C+ if this is urgent?~
I can pick it up as C+ otherwise 👋
Sorry for the confusion. I will review today
Hi @dangrous , Currently I am able to verify the proposals only in offline mode since the backend change is not in production yet and current backend response is disabling the Delayed Submission. Both the proposals are almost same. Should I wait for the backend change to come to staging and verify or provide the proposal approval now?
@abdulrahuman5196, FYI the first proposal doesn't cover updating the setWorkspaceAutoReportingFrequency
in WorkspaceWorkflowsPage
which would have definitely caused regression. Please take that into consideration when evaluating proposals. Thanks!
@Krishna2323 C+ knows the best i think,
Also the point you mentioned is mere implementation detail and not has any new addition to the proposal, thanks, waiting for your analysis @abdulrahuman5196 🙇
@twilight2294 you clearly missed out that important implementation and here it's important to fix all places because the solution is very straightforward. Please wait for C+ decision, I just made my point infront of @abdulrahuman5196.
you clearly missed out that important implementation and here it's important to fix all places because the solution is very straightforward
I guess that is upto the C+ to decide, so i request you to please be patient here @Krishna2323 🙏
I anyway think that you just copied my proposal and are now just making statements to change course here
@abdulrahuman5196 also note that according to new guidelines, unit/ UI tests are also important and i think should be given a priority as it is mentioned that we are increasing the quality of the app and need to have unit / ui tests whereever we can so my proposal is complete in this sense, and @Krishna2323 didn't suggest any UI/ unit tests, so their proposal is incomplete anyway
Hi @dangrous , Currently I am able to verify the proposals only in offline mode since the backend change is not in production yet and current backend response is disabling the Delayed Submission. Both the proposals are almost same. Should I wait for the backend change to come to staging and verify or provide the proposal approval now?
Backend code needed a fix, which is now in review. So we can wait a few days if you like!
@dangrous, @NicMendonca, @abdulrahuman5196 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
@dangrous any update here?
BE PR is now merged, just waiting for deploy
@abdulrahuman5196 friendly bump
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: v9.0.93-3 Issue reported by: @MitchExpensify Slack conversation (hyperlinked to channel name): Internal https://expensify.slack.com/archives/C07HPDRELLD/p1738628148608039
Problem:
Data shows that the majority of our paying customers actively use workspace features that are disabled by default in New Expensify. For example, over 70% of Collect workspaces have Scheduled Submit set to Manual or Off but "Delayed submission" is disabled by default in New Expensify workspaces. This misalignment adds unnecessary friction to the onboarding process and risks undermining customer satisfaction by not meeting their expectations more directly in the window shopping phase, thus risking conversion.
Solution
Set "Delayed submission" to Manually by default on new Workspaces likely to have more than one member:
Action Performed:
Situation 1: introSelected value is newDotManageTeam
Situation 2: introSelected value is empty
Situation 3: Bottom Up
Expected Result (New Feature):
See the "Delayed submission" feature enabled and set to "Manually in the "Workflows" tab
Actual Result:
"Delayed submission" feature is disabled in the "Workflows" tab
Workaround:
Edit the setting manually
Platforms:
Which of our officially supported platforms is this issue occurring on?
View all open jobs on GitHub
Issue Owner
Current Issue Owner: @abdulrahuman5196