Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
4.03k stars 3.03k forks source link

HybridApp AdHoc runs fail if no Mobile-Expensify PR is provided #56369

Closed Julesssss closed 6 days ago

Julesssss commented 1 week ago

Problem

When running an AdHoc HybridApp build, the run fails if no Mobile-Expensify PR is included in the description.

Example run: https://github.com/Expensify/App/actions/runs/13141580686/job/36669786276

Solution

We previously fell back to main and should do the same thing again. It looks like the bug occurs when the link is completely deleted instead of leaving the placeholder.

Julesssss commented 1 week ago

Hey @jnowakow, I think this regression occured after yesterday's PR.

Julesssss commented 1 week ago

I tried to fallback to main in this PR but have some unresolved formatting issues in my workflow.

jnowakow commented 1 week ago

@Julesssss it was issue with syntax :/ I opened PR with fix

melvin-bot[bot] commented 6 days ago

@Julesssss Huh... This is 4 days overdue. Who can take care of this?

Julesssss commented 6 days ago

Second PR in review here