Closed ishpaul777 closed 1 week ago
@alitoshmatov @MarioExpensify One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]
@alitoshmatov Please ignore π
π§ @MarioExpensify has triggered a test build. You can view the workflow run here.
:test_tube::test_tube: Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! :test_tube::test_tube: | Android :robot: | iOS :apple: |
---|---|---|
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/56370/index.html | https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/56370/index.html | |
Desktop :computer: | Web :spider_web: | |
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/56370/NewExpensify.dmg | https://56370.pr-testing.expensify.com | |
:eyes: View the workflow run that generated this build :eyes:
@mananjadhav are you able to install the android app ? it throw error for me
Will try now.
I was able to download it and it is working.
https://github.com/user-attachments/assets/73a5324d-ea1e-4bd7-a7c1-4cd051b7ee61
maybe its just me and android emulator thing, @MarioExpensify Thank you!
@mananjadhav no, I don't think we have anything like an ignoreList for the contacts. I would suggest we move forward with current approach but create a list if we end up having more users to ignore.
Just tried and it worked fine for me.
@mananjadhav no, I don't think we have anything like an ignoreList for the contacts. I would suggest we move forward with current approach but create a list if we end up having more users to ignore.
Okay great. I am left with testing on 2-3 platforms. Will be finishing in next 10 mins.
### Fixed Issues
section aboveTests
sectionQA steps
sectiontoggleReport
and not onIconClick
).src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components using Avatar
have been tested & I retested again)/** comment above it */
this
properly so there are no scoping issues (i.e. for onClick={this.submit}
the method this.submit
should be bound to this
in the constructor)this
are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this);
if this.submit
is never passed to a component event handler like onClick
)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG
)Avatar
is modified, I verified that Avatar
is working as expected in all cases)Design
label and/or tagged @Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test
steps.:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.
π Cherry-picked to staging by https://github.com/MarioExpensify in version: 9.0.94-7 π
platform | result |
---|---|
π€ android π€ | success β |
π₯ desktop π₯ | success β |
π iOS π | success β |
πΈ web πΈ | success β |
π€π android HybridApp π€π | failure β |
ππ iOS HybridApp ππ | failure β |
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.
π Cherry-picked to staging by https://github.com/MarioExpensify in version: 9.0.94-7 π
platform | result |
---|---|
π€ android π€ | success β |
π₯ desktop π₯ | success β |
π iOS π | success β |
πΈ web πΈ | success β |
π€π android HybridApp π€π | failure β |
ππ iOS HybridApp ππ | failure β |
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.
π Cherry-picked to staging by https://github.com/MarioExpensify in version: 9.0.94-7 π
platform | result |
---|---|
π€ android π€ | success β |
π₯ desktop π₯ | success β |
π iOS π | success β |
πΈ web πΈ | success β |
π€π android HybridApp π€π | cancelled πͺ |
ππ iOS HybridApp ππ | failure β |
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.
π Cherry-picked to staging by https://github.com/MarioExpensify in version: 9.0.94-10 π
platform | result |
---|---|
π€ android π€ | success β |
π₯ desktop π₯ | success β |
π iOS π | success β |
πΈ web πΈ | success β |
π€π android HybridApp π€π | success β |
ππ iOS HybridApp ππ | success β |
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.
π Deployed to production by https://github.com/AndrewGable in version: 9.0.94-25 π
platform | result |
---|---|
π€ android π€ | true β |
π₯ desktop π₯ | cancelled πͺ |
π iOS π | success β |
πΈ web πΈ | success β |
π€π android HybridApp π€π | failure β |
ππ iOS HybridApp ππ | failure β |
π Deployed to production by https://github.com/AndrewGable in version: 9.0.94-25 π
platform | result |
---|---|
π€ android π€ | true β |
π₯ desktop π₯ | success β |
π iOS π | success β |
πΈ web πΈ | success β |
π€π android HybridApp π€π | failure β |
ππ iOS HybridApp ππ | failure β |
Explanation of Change
Fixed Issues
$ https://github.com/Expensify/App/issues/56351 PROPOSAL:
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
https://github.com/user-attachments/assets/79a8dbf3-5456-4604-ae12-c0fac5d155cdiOS: Native
https://github.com/user-attachments/assets/d12f2c06-4000-4532-b9df-0f1f7853958fiOS: mWeb Safari
https://github.com/user-attachments/assets/5c3cd9f5-976c-45fe-baa8-3413e80e5c92MacOS: Chrome / Safari
https://github.com/user-attachments/assets/150c506d-f093-4718-a196-c2bdbf0f5aa2MacOS: Desktop
https://github.com/user-attachments/assets/fe90a769-3401-4a58-9804-615ef2f35af3