Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
4.03k stars 3.03k forks source link

[CP Staging] [fix] Setup specialist appears in member list and throws error when invited #56370

Closed ishpaul777 closed 1 week ago

ishpaul777 commented 1 week ago

Explanation of Change

Fixed Issues

$ https://github.com/Expensify/App/issues/56351 PROPOSAL:

Tests

  1. Create a new Gmail account.
  2. Select "Something else" during onboarding and complete the flow.
  3. Create a new workspace.
  4. Go to Workspace settings > Members.
  5. Click Invite member.
  6. verify Setup specialist (fake one without a profile picture) is not in member list

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Android: Native
Android: mWeb Chrome https://github.com/user-attachments/assets/79a8dbf3-5456-4604-ae12-c0fac5d155cd
iOS: Native https://github.com/user-attachments/assets/d12f2c06-4000-4532-b9df-0f1f7853958f
iOS: mWeb Safari https://github.com/user-attachments/assets/5c3cd9f5-976c-45fe-baa8-3413e80e5c92
MacOS: Chrome / Safari https://github.com/user-attachments/assets/150c506d-f093-4718-a196-c2bdbf0f5aa2
MacOS: Desktop https://github.com/user-attachments/assets/fe90a769-3401-4a58-9804-615ef2f35af3
melvin-bot[bot] commented 1 week ago

@alitoshmatov @MarioExpensify One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ishpaul777 commented 1 week ago

@alitoshmatov Please ignore πŸ™‡

github-actions[bot] commented 1 week ago

🚧 @MarioExpensify has triggered a test build. You can view the workflow run here.

github-actions[bot] commented 1 week ago
:test_tube::test_tube: Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! :test_tube::test_tube: Android :robot: iOS :apple:
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/56370/index.html https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/56370/index.html
Android iOS
Desktop :computer: Web :spider_web:
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/56370/NewExpensify.dmg https://56370.pr-testing.expensify.com
Desktop Web

:eyes: View the workflow run that generated this build :eyes:

mananjadhav commented 1 week ago

Screenshots/Videos

Android: Native https://github.com/user-attachments/assets/8e634f2c-bd97-4d7a-9ea8-7b5132cc63d0
Android: mWeb Chrome ![mweb-chrome-expense-errors](https://github.com/user-attachments/assets/8c2facad-b7e7-45e0-a603-38b97c98bc5d)
iOS: Native ![ios-members-error](https://github.com/user-attachments/assets/fa0a9d01-0920-4a6a-80da-9aa84c215530)
iOS: mWeb Safari ![mweb-safari-expense-errors](https://github.com/user-attachments/assets/fab06939-914d-4ba6-a413-2bae8c0b68cb)
MacOS: Chrome / Safari web-members-error
MacOS: Desktop desktop-members-error
ishpaul777 commented 1 week ago

@mananjadhav are you able to install the android app ? it throw error for me

Screenshot 2025-02-05 at 1 57 26β€―AM
mananjadhav commented 1 week ago

Will try now.

MarioExpensify commented 1 week ago

I was able to download it and it is working.

WhatsApp Image 2025-02-04 at 17 32 56

https://github.com/user-attachments/assets/73a5324d-ea1e-4bd7-a7c1-4cd051b7ee61

ishpaul777 commented 1 week ago

maybe its just me and android emulator thing, @MarioExpensify Thank you!

MarioExpensify commented 1 week ago

@mananjadhav no, I don't think we have anything like an ignoreList for the contacts. I would suggest we move forward with current approach but create a list if we end up having more users to ignore.

mananjadhav commented 1 week ago

Just tried and it worked fine for me.

mananjadhav commented 1 week ago

@mananjadhav no, I don't think we have anything like an ignoreList for the contacts. I would suggest we move forward with current approach but create a list if we end up having more users to ignore.

Okay great. I am left with testing on 2-3 platforms. Will be finishing in next 10 mins.

mananjadhav commented 1 week ago

Reviewer Checklist

OSBotify commented 1 week ago

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions[bot] commented 1 week ago

πŸš€ Cherry-picked to staging by https://github.com/MarioExpensify in version: 9.0.94-7 πŸš€

platform result
πŸ€– android πŸ€– success βœ…
πŸ–₯ desktop πŸ–₯ success βœ…
🍎 iOS 🍎 success βœ…
πŸ•Έ web πŸ•Έ success βœ…
πŸ€–πŸ”„ android HybridApp πŸ€–πŸ”„ failure ❌
πŸŽπŸ”„ iOS HybridApp πŸŽπŸ”„ failure ❌

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

github-actions[bot] commented 1 week ago

πŸš€ Cherry-picked to staging by https://github.com/MarioExpensify in version: 9.0.94-7 πŸš€

platform result
πŸ€– android πŸ€– success βœ…
πŸ–₯ desktop πŸ–₯ success βœ…
🍎 iOS 🍎 success βœ…
πŸ•Έ web πŸ•Έ success βœ…
πŸ€–πŸ”„ android HybridApp πŸ€–πŸ”„ failure ❌
πŸŽπŸ”„ iOS HybridApp πŸŽπŸ”„ failure ❌

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

github-actions[bot] commented 1 week ago

πŸš€ Cherry-picked to staging by https://github.com/MarioExpensify in version: 9.0.94-7 πŸš€

platform result
πŸ€– android πŸ€– success βœ…
πŸ–₯ desktop πŸ–₯ success βœ…
🍎 iOS 🍎 success βœ…
πŸ•Έ web πŸ•Έ success βœ…
πŸ€–πŸ”„ android HybridApp πŸ€–πŸ”„ cancelled πŸ”ͺ
πŸŽπŸ”„ iOS HybridApp πŸŽπŸ”„ failure ❌

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

github-actions[bot] commented 1 week ago

πŸš€ Cherry-picked to staging by https://github.com/MarioExpensify in version: 9.0.94-10 πŸš€

platform result
πŸ€– android πŸ€– success βœ…
πŸ–₯ desktop πŸ–₯ success βœ…
🍎 iOS 🍎 success βœ…
πŸ•Έ web πŸ•Έ success βœ…
πŸ€–πŸ”„ android HybridApp πŸ€–πŸ”„ success βœ…
πŸŽπŸ”„ iOS HybridApp πŸŽπŸ”„ success βœ…

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

github-actions[bot] commented 1 week ago

πŸš€ Deployed to production by https://github.com/AndrewGable in version: 9.0.94-25 πŸš€

platform result
πŸ€– android πŸ€– true ❌
πŸ–₯ desktop πŸ–₯ cancelled πŸ”ͺ
🍎 iOS 🍎 success βœ…
πŸ•Έ web πŸ•Έ success βœ…
πŸ€–πŸ”„ android HybridApp πŸ€–πŸ”„ failure ❌
πŸŽπŸ”„ iOS HybridApp πŸŽπŸ”„ failure ❌
github-actions[bot] commented 1 week ago

πŸš€ Deployed to production by https://github.com/AndrewGable in version: 9.0.94-25 πŸš€

platform result
πŸ€– android πŸ€– true ❌
πŸ–₯ desktop πŸ–₯ success βœ…
🍎 iOS 🍎 success βœ…
πŸ•Έ web πŸ•Έ success βœ…
πŸ€–πŸ”„ android HybridApp πŸ€–πŸ”„ failure ❌
πŸŽπŸ”„ iOS HybridApp πŸŽπŸ”„ failure ❌