Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
4.03k stars 3.03k forks source link

Expense - App back button in the main chat is not responsive after deleting the expense #56373

Closed vincdargento closed 1 week ago

vincdargento commented 1 week ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.94-1 Reproducible in staging?: Yes Reproducible in production?: No If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Email or phone of affected tester (no customers): applausetester+230932@applause.expensifail.com Issue reported by: Applause Internal Team Device used: iPhone 15 Pro Max / iOS 18.2 App Component: Money Requests

Action Performed:

  1. Launch ND or hybrid app.
  2. Open FAB > Create expense > Manual.
  3. Enter amount > Next.
  4. Select your own account (self DM) and submit the expense.
  5. In self DM, tap on the expense preview.
  6. Write anything in the report to create a draft.
  7. Tap back button twice to go back to LHN.
  8. Tap on the report with draft.
  9. Tap on the report header.
  10. Tap Delete expense.
  11. Delete the expense.
  12. Tap app back button in self DM.

Expected Result:

App will return to LHN.

Actual Result:

App does not return to LHN because app back button is not responsive.

Workaround:

Unknown

Platforms:

Screenshots/Videos

https://github.com/user-attachments/assets/094e798f-e133-43f5-9407-8dc760cd095e

View all open jobs on GitHub

melvin-bot[bot] commented 1 week ago

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

melvin-bot[bot] commented 1 week ago

Triggered auto assignment to @aldo-expensify (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

melvin-bot[bot] commented 1 week ago

💬 A slack conversation has been started in #expensify-open-source

github-actions[bot] commented 1 week ago

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.
vincdargento commented 1 week ago

@twisterdotcom FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

aldo-expensify commented 1 week ago

I'm not being able to reproduce this, the back button works fine for me (I tried in Android native and in Macos Chrome with a small screen so the back button appears).

From playing with it, I think that back button simply goes to the previous page we have in the stack. If it is not doing nothing, it sounds like the history stack is empty or has the same page many times (is that last case possible)?

aldo-expensify commented 1 week ago

Since I'm not being able to reproduce, I'm inclined to remove this as a DeployBlocker and add Needs Reproduction

twisterdotcom commented 1 week ago

I think if we can't reproduce actually, we should close it.