Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
4.02k stars 3.01k forks source link

[HybridApp] iOS: Push notifications are not received in dev #56377

Open arosiclair opened 5 days ago

arosiclair commented 5 days ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: N/A Reproducible in staging?: N/A Reproducible in production?: N/A If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Email or phone of affected tester (no customers): N/A Logs: N/A Expensify/Expensify Issue URL: N/A Issue reported by: @arosiclair Slack conversation (hyperlinked to channel name): https://expensify.slack.com/archives/C01RJ1RCK8D/p1738187074240489

Action Performed:

  1. Run HybridApp iOS in dev
  2. Login
  3. Accept push notification permission
  4. Send a DM to yourself

Expected Result:

A push notification is received

Actual Result:

Push notifications are NOT received

Workaround:

Manually set inProduction in AirshipConfig.plist

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

melvin-bot[bot] commented 5 days ago

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

arosiclair commented 5 days ago

I found the root cause of this in this slack thread with Ryan at airship. In our AirshipConfig.plist, detectProvisioningMode does not work in dev and it uses the production mode instead. The workaround is to disable that and set inProduction = false which fixes push notifications. We just need to fix this so that it doesn't require any manual steps for devs.