Closed Christinadobrzyn closed 4 days ago
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member?
cc @NicMendonca
@madmax330 @NicMendonca One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]
A preview of your ExpensifyHelp changes have been deployed to https://fe30f1d6.helpdot.pages.dev ā”ļø
Hi @NicMendonca thank you for reviewing this! Here's a link to the drafted article - https://097588a0.helpdot.pages.dev/articles/new-expensify/connect-credit-cards/personal-cards
Here's the slack convo about creating this 'placeholder' article. Please feel free to reach out with any questions!
@Christinadobrzyn does this need to be capitilized?
Yes, good catch @NicMendonca - the title is capitalized. The article is here for your review! https://fe30f1d6.helpdot.pages.dev/articles/new-expensify/connect-credit-cards/Personal-Cards
@NicMendonca I will wait for you to approve before merging
ready for you @madmax330 š
### Fixed Issues
section aboveTests
sectionQA steps
sectiontoggleReport
and not onIconClick
).src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components using Avatar
have been tested & I retested again)/** comment above it */
this
properly so there are no scoping issues (i.e. for onClick={this.submit}
the method this.submit
should be bound to this
in the constructor)this
are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this);
if this.submit
is never passed to a component event handler like onClick
)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG
)Avatar
is modified, I verified that Avatar
is working as expected in all cases)Design
label and/or tagged @Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test
steps.š Deployed to staging by https://github.com/madmax330 in version: 9.0.95-0 š
platform | result |
---|---|
š¤ android š¤ | success ā |
š„ desktop š„ | success ā |
š iOS š | success ā |
šø web šø | success ā |
š¤š android HybridApp š¤š | success ā |
šš iOS HybridApp šš | success ā |
Explanation of Change
Tracking GH: https://github.com/Expensify/Expensify/issues/462432
Creating a personal card page in NewDot help site. This feature isn't available yet so this will be a placeholder. The intention of the article is to provide customers with a self-service method to find out more about personal cards in NewDot.
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.