Open greg-schroeder opened 5 days ago
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member?
cc @laurenreidexpensify
@ishpaul777 @laurenreidexpensify One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]
A preview of your ExpensifyHelp changes have been deployed to https://a3cb3875.helpdot.pages.dev ⚡️
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member?
cc @bfitzexpensify
@Pujan92 @ @bfitzexpensify One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]
Oops, yes, thanks @ishpaul777!
@laurenreidexpensify Plz remove me from reviewer, Thanks!
@laurenreidexpensify Okay. I edited one word to make it apply to "all" receipts instead of "both".
@greg-schroeder nice thanks, but it still says both in the last sentence?
From there, simply upload the combined PDF to the expense to capture both.
Explanation of Change
Adding a small addendum to the FAQ for this article to accommodate multiple receipt uploads
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/465282
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videosundefined