Closed os-botify[bot] closed 1 week ago
This pull request has merge conflicts and can not be automatically merged. :disappointed: Please manually resolve the conflicts, push your changes, and then request another reviewer to review and merge. Important: There may be conflicts that GitHub is not able to detect, so please carefully review this pull request before approving.
@deetergp Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]
PR template could use some work. Plus we don't want lint and tests to be skipped on this type of PR where I had to manually resolve changes. So I definitely have some follow-up tasks for this. But for now I'm going to test this and post a screen recording
I think the gtm (google tag manager) error in the screen recording is a local setup thing that's a red herring. pretty sure this is passing local testing:
https://github.com/user-attachments/assets/89b47604-ba6d-4c6b-9510-77d0aa42c85d
### Fixed Issues
section aboveTests
sectionQA steps
sectiontoggleReport
and not onIconClick
).src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components using Avatar
have been tested & I retested again)/** comment above it */
this
properly so there are no scoping issues (i.e. for onClick={this.submit}
the method this.submit
should be bound to this
in the constructor)this
are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this);
if this.submit
is never passed to a component event handler like onClick
)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG
)Avatar
is modified, I verified that Avatar
is working as expected in all cases)Design
label and/or tagged @Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test
steps.
🍒 Cherry pick https://github.com/Expensify/App/pull/56370 to staging 🍒 This PR had conflicts when we tried to cherry-pick it to staging. You'll need to manually perform the cherry-pick, using the following steps:
(cherry picked from commit c28f64d6405913208910c5c6c705d67c452ede7e)" -m "(CP triggered by roryabraham)"