Closed muttmuure closed 2 days ago
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member?
cc @strepanier03
@Pujan92 @strepanier03 One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]
A preview of your ExpensifyHelp changes have been deployed to https://c7a82086.helpdot.pages.dev ⚡️
@muttmuure - I just reviewed the build and noticed some formatting in an FAQ was off. It looks like the bullet points and returns aren't working.
Then, in the last FAQ, I think the two bullet items would stand out better as bullet points; what do you think?
@muttmuure happy to review this again if you make changes, just let me know!
@strepanier03 Can you unassign me as I think C+ review is not needed here
Hm, it looks like changes have already been made to main.
I'm not sure how to fix that right now so I'm going to create a new PR
Explanation of Change
Fixed Issues
$https://github.com/Expensify/Expensify/issues/463224 PROPOSAL:
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop