Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
4.03k stars 3.03k forks source link

[No QA] Don't skip tests for manual CPs #56392

Open roryabraham opened 1 week ago

roryabraham commented 1 week ago

Explanation of Change

  1. Don't skip tests or lint for manual CPs
  2. Fix the PR description (bad example here, fixed example here)

Fixed Issues

$ n/a

Tests

tested changes to gh cli part locally (results here)

Offline tests

n/a

QA Steps

n/a

PR Author Checklist

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop
melvin-bot[bot] commented 1 week ago

@cristipaval Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

AndrewGable commented 1 week ago

PR Author Checklist

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop