Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
4.02k stars 3.01k forks source link

[No QA]Add iOS Certificates.p12 from `op` #56394

Closed AndrewGable closed 5 days ago

AndrewGable commented 5 days ago

Explanation of Change

Adds missing certificate for build:

[02:09:00]: --------------------------------
[02:09:00]: --- Step: import_certificate ---
[02:09:00]: --------------------------------
+---------------------------------------------------------------------------------+
|                                  Lane Context                                   |
+---------------------------+-----------------------------------------------------+
| PLATFORM_NAME             | ios                                                 |
| LANE_NAME                 | ios build_hybrid                                    |
| KEYCHAIN_PATH             | ~/Library/Keychains/ios-build.keychain              |
| ORIGINAL_DEFAULT_KEYCHAIN | "/Users/runner/Library/Keychains/login.keychain-db" |
+---------------------------+-----------------------------------------------------+
[02:09:00]: Called from Fastfile at line 3[34](https://github.com/Expensify/App/actions/runs/13147714332/job/36692031290#step:15:35)
[02:09:00]: ```
[02:09:00]:     332:      )
[02:09:00]:     333:    
[02:09:00]:  => 334:      import_certificate(
[02:09:00]:     3[35](https://github.com/Expensify/App/actions/runs/13147714332/job/36692031290#step:15:36):        certificate_path: "./Certificates.p12",
[02:09:00]:     3[36](https://github.com/Expensify/App/actions/runs/13147714332/job/36692031290#step:15:37):        keychain_name: "ios-build.keychain",
[02:09:00]: ```
[02:09:00]: Could not find file './Certificates.p12'

Tests

QA Steps

PR Author Checklist

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop
melvin-bot[bot] commented 5 days ago

@carlosmiceli Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

roryabraham commented 5 days ago

Reviewer Checklist

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop
OSBotify commented 5 days ago

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions[bot] commented 5 days ago

🚀 Cherry-picked to staging by https://github.com/roryabraham in version: 9.0.94-8 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅
🤖🔄 android HybridApp 🤖🔄 success ✅
🍎🔄 iOS HybridApp 🍎🔄 success ✅
github-actions[bot] commented 4 days ago

🚀 Cherry-picked to staging by https://github.com/roryabraham in version: 9.0.94-10 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅
🤖🔄 android HybridApp 🤖🔄 success ✅
🍎🔄 iOS HybridApp 🍎🔄 success ✅
github-actions[bot] commented 3 days ago

🚀 Deployed to production by https://github.com/AndrewGable in version: 9.0.94-25 🚀

platform result
🤖 android 🤖 true ❌
🖥 desktop 🖥 cancelled 🔪
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅
🤖🔄 android HybridApp 🤖🔄 failure ❌
🍎🔄 iOS HybridApp 🍎🔄 failure ❌
github-actions[bot] commented 3 days ago

🚀 Deployed to production by https://github.com/AndrewGable in version: 9.0.94-25 🚀

platform result
🤖 android 🤖 true ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅
🤖🔄 android HybridApp 🤖🔄 failure ❌
🍎🔄 iOS HybridApp 🍎🔄 failure ❌