Closed c3024 closed 1 week ago
@mjasikowski Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]
### Fixed Issues
section aboveTests
sectionQA steps
sectiontoggleReport
and not onIconClick
).src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components using Avatar
have been tested & I retested again)/** comment above it */
this
properly so there are no scoping issues (i.e. for onClick={this.submit}
the method this.submit
should be bound to this
in the constructor)this
are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this);
if this.submit
is never passed to a component event handler like onClick
)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG
)Avatar
is modified, I verified that Avatar
is working as expected in all cases)Design
label and/or tagged @Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test
steps.:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.
thanks @c3024!
š Deployed to staging by https://github.com/mjasikowski in version: 9.0.95-0 š
platform | result |
---|---|
š¤ android š¤ | success ā |
š„ desktop š„ | success ā |
š iOS š | success ā |
šø web šø | success ā |
š¤š android HybridApp š¤š | success ā |
šš iOS HybridApp šš | success ā |
š Deployed to production by https://github.com/Julesssss in version: 9.0.95-6 š
platform | result |
---|---|
š¤ android š¤ | true ā |
š„ desktop š„ | success ā |
š iOS š | success ā |
šø web šø | success ā |
š¤š android HybridApp š¤š | failure ā |
šš iOS HybridApp šš | failure ā |
Explanation of Change
This PR checks if HybridAppModules exists before calling a function on it like it does everywhere else on the App.
Fixed Issues
$ https://github.com/Expensify/App/pull/54296#discussion_r1940447656 PROPOSAL: https://github.com/Expensify/App/pull/54296#discussion_r1940447656
Tests
Prerequisite:
Steps:
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
Same as Tests
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
https://github.com/user-attachments/assets/0612a3fd-514a-429a-9f82-69e55af451f2Android: mWeb Chrome
https://github.com/user-attachments/assets/98c87dff-334c-4e33-877f-5b568562420aiOS: Native
https://github.com/user-attachments/assets/8d42c742-67ee-4efb-b6b9-2c927446e1c2iOS: mWeb Safari
https://github.com/user-attachments/assets/075d08e2-1c72-4ba0-b616-82c73e2f4198MacOS: Chrome / Safari
https://github.com/user-attachments/assets/c41f3835-0a9c-4cd7-ab70-fb4a458198a6MacOS: Desktop
https://github.com/user-attachments/assets/05263d4f-be85-4156-baf1-cbbb83f26e55