Closed bernhardoj closed 6 days ago
@parasharrajat Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]
https://github.com/user-attachments/assets/3ad02111-0efe-48b8-8d1b-743278bc8857
https://github.com/user-attachments/assets/59d46875-c14d-41ac-a2de-9ccdc480dff7
https://github.com/user-attachments/assets/876705cc-4df0-4713-8ee6-d7bb3d60673a
https://github.com/user-attachments/assets/2d17b52c-943a-4ee5-8257-322bc03ed202
https://github.com/user-attachments/assets/0b862b42-dbc1-487c-99e4-9b66c6c87e1b
Build error. But output is the same as other platforms.
@luacmartins Oh, I forgot to add the test. Added.
π Deployed to staging by https://github.com/luacmartins in version: 9.0.96-0 π
platform | result |
---|---|
π€ android π€ | success β |
π₯ desktop π₯ | success β |
π iOS π | success β |
πΈ web πΈ | success β |
π€π android HybridApp π€π | success β |
ππ iOS HybridApp ππ | success β |
π Deployed to production by https://github.com/Julesssss in version: 9.0.96-1 π
platform | result |
---|---|
π€ android π€ | true β |
π₯ desktop π₯ | success β |
π iOS π | success β |
πΈ web πΈ | success β |
π€π android HybridApp π€π | failure β |
ππ iOS HybridApp ππ | failure β |
Explanation of Change
Fixed Issues
$ https://github.com/Expensify/App/issues/55012 PROPOSAL: https://github.com/Expensify/App/issues/55012#issuecomment-2580554993
Tests
Same as QA Steps
Offline tests
Same as QA Steps
QA Steps
Pre-condition: Be a member of a workspace with more than 2 members
NOTE: open the announce room at least once to load the data
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
https://github.com/user-attachments/assets/9802f09b-aba7-4b12-a2aa-0657e6006614Android: mWeb Chrome
https://github.com/user-attachments/assets/538ef9e4-08ce-46a5-8d91-cf846f106d42iOS: Native
https://github.com/user-attachments/assets/78c72123-d719-4106-856a-9dcb13ec501ciOS: mWeb Safari
https://github.com/user-attachments/assets/645c9201-21eb-45e9-881f-5ede9699360eMacOS: Chrome / Safari
https://github.com/user-attachments/assets/feb53a05-0e2c-466a-a54a-c3c527f38266MacOS: Desktop
https://github.com/user-attachments/assets/3e9f7618-6de9-4938-a158-8b4d12d608d6