Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
4.03k stars 3.03k forks source link

Filter out read only report from share log options #56398

Closed bernhardoj closed 6 days ago

bernhardoj commented 1 week ago

Explanation of Change

Fixed Issues

$ https://github.com/Expensify/App/issues/55012 PROPOSAL: https://github.com/Expensify/App/issues/55012#issuecomment-2580554993

Tests

Same as QA Steps

Offline tests

Same as QA Steps

QA Steps

Pre-condition: Be a member of a workspace with more than 2 members

  1. Open Settings > Troubleshoot
  2. Enable client side logging
  3. Press View debug console > Share log
  4. Verify there is no announce room of the workspace from pre-condition on the list

NOTE: open the announce room at least once to load the data

PR Author Checklist

Screenshots/Videos

Android: Native https://github.com/user-attachments/assets/9802f09b-aba7-4b12-a2aa-0657e6006614
Android: mWeb Chrome https://github.com/user-attachments/assets/538ef9e4-08ce-46a5-8d91-cf846f106d42
iOS: Native https://github.com/user-attachments/assets/78c72123-d719-4106-856a-9dcb13ec501c
iOS: mWeb Safari https://github.com/user-attachments/assets/645c9201-21eb-45e9-881f-5ede9699360e
MacOS: Chrome / Safari https://github.com/user-attachments/assets/feb53a05-0e2c-466a-a54a-c3c527f38266
MacOS: Desktop https://github.com/user-attachments/assets/3e9f7618-6de9-4938-a158-8b4d12d608d6
melvin-bot[bot] commented 1 week ago

@parasharrajat Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

parasharrajat commented 1 week ago

Screenshots

:black_square_button: iOS / native

https://github.com/user-attachments/assets/3ad02111-0efe-48b8-8d1b-743278bc8857

:black_square_button: iOS / Safari

https://github.com/user-attachments/assets/59d46875-c14d-41ac-a2de-9ccdc480dff7

:black_square_button: MacOS / Desktop

https://github.com/user-attachments/assets/876705cc-4df0-4713-8ee6-d7bb3d60673a

:black_square_button: MacOS / Chrome

https://github.com/user-attachments/assets/2d17b52c-943a-4ee5-8257-322bc03ed202

:black_square_button: Android / Chrome

https://github.com/user-attachments/assets/0b862b42-dbc1-487c-99e4-9b66c6c87e1b

:black_square_button: Android / native

Build error. But output is the same as other platforms.

bernhardoj commented 1 week ago

@luacmartins Oh, I forgot to add the test. Added.

github-actions[bot] commented 6 days ago

πŸš€ Deployed to staging by https://github.com/luacmartins in version: 9.0.96-0 πŸš€

platform result
πŸ€– android πŸ€– success βœ…
πŸ–₯ desktop πŸ–₯ success βœ…
🍎 iOS 🍎 success βœ…
πŸ•Έ web πŸ•Έ success βœ…
πŸ€–πŸ”„ android HybridApp πŸ€–πŸ”„ success βœ…
πŸŽπŸ”„ iOS HybridApp πŸŽπŸ”„ success βœ…
github-actions[bot] commented 5 days ago

πŸš€ Deployed to production by https://github.com/Julesssss in version: 9.0.96-1 πŸš€

platform result
πŸ€– android πŸ€– true ❌
πŸ–₯ desktop πŸ–₯ success βœ…
🍎 iOS 🍎 success βœ…
πŸ•Έ web πŸ•Έ success βœ…
πŸ€–πŸ”„ android HybridApp πŸ€–πŸ”„ failure ❌
πŸŽπŸ”„ iOS HybridApp πŸŽπŸ”„ failure ❌