Open Themoonalsofall opened 5 days ago
@alitoshmatov Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]
@Themoonalsofall Please fill out the testing steps and recordings based on related issue. I am also not sure about [No QA]
title, let's leave that decision to internal engineer
### Fixed Issues
section aboveTests
sectionQA steps
sectiontoggleReport
and not onIconClick
).src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components using Avatar
have been tested & I retested again)/** comment above it */
this
properly so there are no scoping issues (i.e. for onClick={this.submit}
the method this.submit
should be bound to this
in the constructor)this
are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this);
if this.submit
is never passed to a component event handler like onClick
)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG
)Avatar
is modified, I verified that Avatar
is working as expected in all cases)Design
label and/or tagged @Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test
steps.@Themoonalsofall Ping me for approval when you are ready
@alitoshmatov added steps and videos
@techievivek can you review this follow up PR. We overlooked some mistakes in previous PR and it got into production. Fortunately this didn't cause any regressions yet.
@techievivek bump here
Explanation of Change
Fixed Issues
$ https://github.com/Expensify/App/issues/52900 PROPOSAL:
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
https://github.com/user-attachments/assets/723d6ffd-6bb1-45ec-a1e8-a1468d394a62Android: mWeb Chrome
https://github.com/user-attachments/assets/723d6ffd-6bb1-45ec-a1e8-a1468d394a62iOS: Native
https://github.com/user-attachments/assets/bbef6757-8802-44fa-bb77-9d25db89eecfiOS: mWeb Safari
https://github.com/user-attachments/assets/bbef6757-8802-44fa-bb77-9d25db89eecfMacOS: Chrome / Safari
https://github.com/user-attachments/assets/58c394b4-c092-400a-bad7-d376f2fba22eMacOS: Desktop
https://github.com/user-attachments/assets/dff33cf2-8691-4198-8294-2f986e7ec128