Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
4.02k stars 3.01k forks source link

Follow up update display name #56399

Open Themoonalsofall opened 5 days ago

Themoonalsofall commented 5 days ago

Explanation of Change

Fixed Issues

$ https://github.com/Expensify/App/issues/52900 PROPOSAL:

Tests

  1. Create a new account
  2. In onboarding modal select 'Manage my team's expenses' and finish onboarding flow
  3. Go to Profile, add a legal name
  4. Verify display name is changed

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

PR Author Checklist

Screenshots/Videos

Android: Native https://github.com/user-attachments/assets/723d6ffd-6bb1-45ec-a1e8-a1468d394a62
Android: mWeb Chrome https://github.com/user-attachments/assets/723d6ffd-6bb1-45ec-a1e8-a1468d394a62
iOS: Native https://github.com/user-attachments/assets/bbef6757-8802-44fa-bb77-9d25db89eecf
iOS: mWeb Safari https://github.com/user-attachments/assets/bbef6757-8802-44fa-bb77-9d25db89eecf
MacOS: Chrome / Safari https://github.com/user-attachments/assets/58c394b4-c092-400a-bad7-d376f2fba22e
MacOS: Desktop https://github.com/user-attachments/assets/dff33cf2-8691-4198-8294-2f986e7ec128
melvin-bot[bot] commented 5 days ago

@alitoshmatov Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

alitoshmatov commented 4 days ago

@Themoonalsofall Please fill out the testing steps and recordings based on related issue. I am also not sure about [No QA] title, let's leave that decision to internal engineer

alitoshmatov commented 4 days ago

Reviewer Checklist

Screenshots/Videos

Android: Native https://github.com/user-attachments/assets/576783e4-ee47-49ed-aeee-9861ff7bb4f8
Android: mWeb Chrome
iOS: Native https://github.com/user-attachments/assets/1db58387-8c94-4a9a-914d-60fa1d986400
iOS: mWeb Safari https://github.com/user-attachments/assets/cf7e6b65-ec96-4d29-96bf-4cec6e91416a
MacOS: Chrome / Safari https://github.com/user-attachments/assets/85e92562-f23d-4d1e-8f05-3612f878c602
MacOS: Desktop https://github.com/user-attachments/assets/a5895900-4f9c-4039-9e00-68571b760a81
alitoshmatov commented 4 days ago

@Themoonalsofall Ping me for approval when you are ready

Themoonalsofall commented 4 days ago

@alitoshmatov added steps and videos

alitoshmatov commented 4 days ago

@techievivek can you review this follow up PR. We overlooked some mistakes in previous PR and it got into production. Fortunately this didn't cause any regressions yet.

Themoonalsofall commented 2 days ago

@techievivek bump here