Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
4.03k stars 3.03k forks source link

[No QA] Fix syntax in testBuildHybrid.yml #56400

Closed jnowakow closed 6 days ago

jnowakow commented 1 week ago

@Julesssss @AndrewGable

Explanation of Change

This PR fixes issue with workflow that crashed because of wrong syntax (eg here)

Fixed Issues

Fixes: https://github.com/Expensify/App/issues/56369

Tests

  1. Trigger adhoc build
  2. Verify it does not fails on getOldDotBranchRef job

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

PR Author Checklist

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop
melvin-bot[bot] commented 1 week ago

@jasperhuangg Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

AndrewGable commented 1 week ago

cc @Julesssss - But I am not sure we can run this on a fork?

Julesssss commented 1 week ago

Ah, thank you. Let me test this before we merge.

Julesssss commented 1 week ago

But I am not sure we can run this on a fork?

I can just copy the small diff locally

jasperhuangg commented 1 week ago

Reviewer Checklist

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop
jasperhuangg commented 1 week ago

@Julesssss feel free to merge if the test run looks good

jnowakow commented 1 week ago

@Julesssss can you check once more? Quotation marks were missing 🀦

Julesssss commented 1 week ago

@Julesssss can you check once more? Quotation marks were missing 🀦

Sure, thanks πŸ‘ I'll need to wait until next week, but will do this asap.

jnowakow commented 6 days ago

@Julesssss could you give it a second run today? πŸ™

Julesssss commented 6 days ago
OSBotify commented 6 days ago

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions[bot] commented 6 days ago

πŸš€ Deployed to staging by https://github.com/Julesssss in version: 9.0.96-0 πŸš€

platform result
πŸ€– android πŸ€– success βœ…
πŸ–₯ desktop πŸ–₯ success βœ…
🍎 iOS 🍎 success βœ…
πŸ•Έ web πŸ•Έ success βœ…
πŸ€–πŸ”„ android HybridApp πŸ€–πŸ”„ success βœ…
πŸŽπŸ”„ iOS HybridApp πŸŽπŸ”„ success βœ…
github-actions[bot] commented 5 days ago

πŸš€ Deployed to production by https://github.com/Julesssss in version: 9.0.96-1 πŸš€

platform result
πŸ€– android πŸ€– true ❌
πŸ–₯ desktop πŸ–₯ success βœ…
🍎 iOS 🍎 success βœ…
πŸ•Έ web πŸ•Έ success βœ…
πŸ€–πŸ”„ android HybridApp πŸ€–πŸ”„ failure ❌
πŸŽπŸ”„ iOS HybridApp πŸŽπŸ”„ failure ❌