Closed jnowakow closed 5 days ago
@nikkiwines Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]
cc @AndrewGable
Tests and QA section could be beefed up here 💪
@AndrewGable done 🫡
@staszekscp said that it was because there was no way to differentiate between staging and production. I'm not aware of what changed in the meantime so I'm not sure how to fully describe testing section. I built app locally with different buildTypes
and variables in .env
and it used different urls and had different badges depending on environment. Would be good if someone with deeper insight could test it before merging.
@jnowakow - We only build the Android and iOS apps once for staging and production. We build the iOS and Android apps with production env and then send it to the staging audience. Then once we want to deploy to production we just move the latest staging version to production audience.
For web and desktop we build it twice, on staging we build with the staging env. On production we build again but using the production env.
🚧 @AndrewGable has triggered a test hybrid app build. You can view the workflow run here.
:test_tube::test_tube: Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! :test_tube::test_tube: | Android :robot: | iOS :apple: |
---|---|---|
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/56401/index.html | https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/56401/index.html | |
Desktop :computer: | Web :spider_web: | |
N/A | N/A | |
N/A | N/A |
:eyes: View the workflow run that generated this build :eyes:
Confirmed via adhoc 👍
### Fixed Issues
section aboveTests
sectionQA steps
sectiontoggleReport
and not onIconClick
).myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components using Avatar
have been tested & I retested again)/** comment above it */
this
properly so there are no scoping issues (i.e. for onClick={this.submit}
the method this.submit
should be bound to this
in the constructor)this
are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this);
if this.submit
is never passed to a component event handler like onClick
)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG
)Avatar
is modified, I verified that Avatar
is working as expected in all cases)Design
label and/or tagged @Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test
steps.:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.
🚀 Deployed to staging by https://github.com/AndrewGable in version: 9.0.97-0 🚀
platform | result |
---|---|
🤖 android 🤖 | success ✅ |
🖥 desktop 🖥 | success ✅ |
🍎 iOS 🍎 | success ✅ |
🕸 web 🕸 | success ✅ |
🤖🔄 android HybridApp 🤖🔄 | success ✅ |
🍎🔄 iOS HybridApp 🍎🔄 | success ✅ |
@jnowakow PR is failing on Android, iOS apps with https://github.com/Expensify/App/issues/56719 Pending validation on Web, mWeb an Desktop
I'm not sure how exactly, but this change caused blockers related to iOS linking, app deep links, ect.
When re-raising this case please add tests for these cases:
🚀 Deployed to production by https://github.com/Julesssss in version: 9.0.97-1 🚀
platform | result |
---|---|
🤖 android 🤖 | true ❌ |
🖥 desktop 🖥 | success ✅ |
🍎 iOS 🍎 | success ✅ |
🕸 web 🕸 | success ✅ |
🤖🔄 android HybridApp 🤖🔄 | failure ❌ |
🍎🔄 iOS HybridApp 🍎🔄 | failure ❌ |
@staszekscp
Explanation of Change
Earlier this check was necessary because there was no way to differentiate between staging and production. Now it's can be removed
Fixed Issues
$ https://github.com/Expensify/App/issues/52199
Tests
Offline tests
Same as in Tests but requests will fail
QA Steps
Verify that on all environments HybridApp has badge corresponding to environment (e.g. staging has the staging badge)
Navigate to the bank account connect flow
Reach the plaid modal
Plaid should point to the Sandbox environment to be able to test it.
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop