Replace Deprecated Methods

Extex101 / motorbike

Motorbike mod for Minetest

Other

4 stars 8 forks source link

Closed AntumDeluge closed 3 years ago

AntumDeluge commented 3 years ago

Replaces deprecated methods (getpos to get_pos, setyaw to set_yaw, etc.)
Adds dependencies to mod.conf

Edit: ~~I'm going to make some changes to this for backward compatibility, then re-submit.~~ (done)

[x] keep depends.txt
[x] ~~keep backward compat with get/set object methods (not sure if this can be done)~~

Edit: It sounds like getpos, setpos, setyaw, etc. methods are so outdated that it is not worth keeping backward compat with them

AntumDeluge commented 3 years ago

I reverted deleting depends.txt to keep backward compatibility.

AntumDeluge commented 3 years ago

I've found some more issues that I want to fix. I am going to close this & re-submit in another pull request with other fixes.

Extex101 commented 3 years ago

Well it's minimum version is 5.0 so no need for backwards compatibility

AntumDeluge commented 3 years ago

~~So, you don't want to update the deprecated set*/get* methods?~~

Oh, oops. This is my old PR. LOL! Hard to keep track of this stuff.

Extex101 commented 3 years ago

Well I mean about the mod.conf information

AntumDeluge commented 3 years ago

Well I mean about the mod.conf information

Ah, okay.