search

ExtremeFiretop / MerlinAutoUpdate-Router

Merlin(A)uto(U)pdate is a Merlin router script which allows you to remotely identify a stable firmware update for an ASUS Merlin router, and automatically download and update via an unattended method directly from the router.
https://www.snbforums.com/threads/merlinau-v1-2-7-the-ultimate-firmware-auto-updater-amtm-addon.91326/
GNU General Public License v3.0
15 stars 1 forks source link

Include Help, About, Force Update, Stable, and Dev Commands. #260

Closed ExtremeFiretop closed 2 months ago

ExtremeFiretop commented 2 months ago

Include Help, About, Force Update, Stable, and Dev Commands.

Martinski4GitHub commented 2 months ago

Include Help, About, Force Update, Stable, and Dev Commands.

I'll review this PR tomorrow. My wife & I started binge-watching a short series on Amazon Prime Video ("Outer Range"). Right now we're on a "bathroom break" and I saw your messages.

We'll talk tomorrow.

ExtremeFiretop commented 2 months ago

Include Help, About, Force Update, Stable, and Dev Commands.

I'll review this PR tomorrow. My wife & I started binge-watching a short series on Amazon Prime Video ("Outer Range"). Right now we're on a "bathroom break" and I saw your messages.

We'll talk tomorrow.

Enjoy the show!

ExtremeFiretop commented 2 months ago

@Martinski4GitHub

I updated the version.txt and the version number in the dev branch early, so this can be tested for you :) While testing, I identified a little mistake, and fixed it in commit: https://github.com/ExtremeFiretop/MerlinAutoUpdate-Router/pull/260/commits/31edb31e17b96f1f8746c403e4319c9e649d05b0

Martinski4GitHub commented 2 months ago

My apologies for the delayed response. My "Higher Power :>)" summoned & asked me to go to the store and buy some groceries and other stuff for tomorrow's family gathering (we're having a 4th of July barbecue) and then helped in the kitchen.

Anyway, I've tested the PR & overall it's working well. However, there are a few places that need some fine-tuning & refactoring. I'll submit a separate PR with my proposed changes.

ExtremeFiretop commented 2 months ago

My apologies for the delayed response. My "Higher Power :>)" summoned & asked me to go to the store and buy some groceries and other stuff for tomorrow's family gathering (we're having a 4th of July barbecue) and then helped in the kitchen.

Anyway, I've tested the PR & overall it's working well. However, there are a few places that need some fine-tuning & refactoring. I'll submit a separate PR with my proposed changes.

Ah yes! The celebrations are incoming! My Canada day was fairly relaxed, spent some time with the family as well, had a BBQ too!

Nice fireworks at the end of the evening, overall a good day :) I'm sure you looking forwards to well earned time off!

Anyways, no worries it's not a rush, thanks for testing the PR! Feel free to submit some adjustments. Is there anything non functional I missed?

ExtremeFiretop commented 2 months ago

Working well so it's approved. I'll submit a separate PR to apply some refactoring & fine-tuning.

That answers my question :)

ExtremeFiretop commented 2 months ago

Synced with Gnuton here: https://github.com/ExtremeFiretop/MerlinAutoUpdate-Router/pull/186/commits/a3dd4551e6c9f3f9731d91396b0000f6e539bfc7