search

ExtremeFiretop / MerlinAutoUpdate-Router

Merlin(A)uto(U)pdate is a Merlin router script which allows you to remotely identify a stable firmware update for an ASUS Merlin router, and automatically download and update via an unattended method directly from the router.
https://www.snbforums.com/threads/merlinau-v1-2-7-the-ultimate-firmware-auto-updater-amtm-addon.91326/
GNU General Public License v3.0
15 stars 1 forks source link

A fix & some refactoring changes. #261

Closed Martinski4GitHub closed 2 months ago

Martinski4GitHub commented 2 months ago
Martinski4GitHub commented 2 months ago

@ExtremeFiretop,

As always, please review & test the PR whenever you have the time. I don't think this new feature is critical functionality so we can take our time to get it out the door.

ExtremeFiretop commented 2 months ago

I'm currently watching some Plex with the girlfriend, but I'll review this first thing! Happy July 4th if I don't talk to you until tomorrow! (I know I'm probably about an hour and a bit early)

Martinski4GitHub commented 2 months ago

I'm currently watching some Plex with the girlfriend, but I'll review this first thing! Happy July 4th if I don't talk to you until tomorrow! (I know I'm probably about an hour and a bit early)

LOL!! Here, we're about to continue binge-watching the Amazon series we started last night. LOL!!

So no worries. We can take our time on this one. Nothing critical.

Enjoy your movie or whatever you're watching & I'll do the same. We deserve some time off!!

ExtremeFiretop commented 2 months ago

I'm currently watching some Plex with the girlfriend, but I'll review this first thing! Happy July 4th if I don't talk to you until tomorrow! (I know I'm probably about an hour and a bit early)

LOL!! Here, we're about to continue binge-watching the Amazon series we started last night. LOL!!

So no worries. We can take our time on this one. Nothing critical.

Enjoy your movie or whatever you're watching & I'll do the same. We deserve some time off!!

Sounds good buddy! We are watching some TV, right now it's some intervention LOL!

I'll be up tomorrow and merge this in in the morning after testing. 😉

ExtremeFiretop commented 2 months ago

Approved the cleanup and I see the bug you mentioned:

image

However, this solution of including the force parameter is not what I had in mind for the menu.

I'll submit another PR in a moment with the original intention, you let me know if you like it or dislike it more than this solution. We can discuss the pros and cons if you'd like.

ExtremeFiretop commented 2 months ago

Synced with Gnuton here: https://github.com/ExtremeFiretop/MerlinAutoUpdate-Router/pull/186/commits/a3dd4551e6c9f3f9731d91396b0000f6e539bfc7