[RFE] Add possibility to schedule the BIG-IP controller to k8s controller/master nodes

mikejoh commented 3 years ago

Description

Today the Deployment manifest template of the F5 BIGIP controller helm chart doesn't have a way of forcing the controller to be scheduled on controller/master nodes. There's two opinonated reasons for this:

Make sure controller workloads doesnt compete with the cluster resources used by "regular" workloads
Although the BIGIP controller isnt vital for the k8s control plane it's vital for other reasons and should not be mixed with other workloads

One way of doing this is (what we've tested) is to add a combination of tolerations and node-selector parameters to the Deployment manifest template.

What we've added to test this so far:

nodeSelector:
  node-role.kubernetes.io/master: ""
tolerations:
- effect: NoSchedule
  key: node-role.kubernetes.io/master

Any input on this?

I could start off with a PR to add the possibility to configure this via values and toggle this within the Deployment manifest template.

Kubernetes Version

v1.18+

Controller Version

v2.2.3

BIG-IP Version

N/A

Helm / Tiller Version

v3.3.1

Diagnostic Information

N/A

trinaths commented 3 years ago

Created CONTCNTR-2429 for PM tracking

trinaths commented 3 years ago

@mikejoh As an external contributor you need to sign the CLA for this project to accept the contributions.

mikejoh commented 3 years ago

@mikejoh As an external contributor you need to sign the CLA for this project to accept the contributions.

Ah, thanks, missed that last part of the contribution guide.. I've sent a signed CLA just now!

F5Networks / charts