search

F5Networks / terraform-azure-bigip-module

Terraform module for Deploying BIG-IP in azure
Apache License 2.0
9 stars 24 forks source link

on boarding template for pre-1.2.1 modules breaks due to breaking change in 1.2.1 #17

Closed mjmenger closed 2 years ago

mjmenger commented 2 years ago

When using versions of the module earlier than 1.2.1, the following line breaks due to a reference to the latest version of the repository. In particular, the following line

curl -o /config/cloud/do_w_admin.json -s --fail --retry 60 -m 10 -L https://raw.githubusercontent.com/F5Networks/terraform-azure-bigip-module/main/config/onboard_do.json

which can be found at https://github.com/F5Networks/terraform-azure-bigip-module/blob/v1.1.1/f5_onboard.tmpl#L22

Because of the way that line is written, it always downloads the latest version of the onboarding template. 1.2.1 introduces additional runtime parameters. Because they do not exist in earlier versions of the module, all modules prior to 1.2.1 will fail upon initial configuration.

RavinderReddyF5 commented 2 years ago

hi @mjmenger , yes i added HOSTNAME RUNTIME Parameter to set HOSTNAME to BIGIP from v1.2.1, and we getting DO config from URL which will always be latest config file will be downloaded. best is to upgrade v1.2.1.

RavinderReddyF5 commented 2 years ago

let me try if i can make anything based on HOSTNAME value not set.

RavinderReddyF5 commented 2 years ago

@mjmenger i pulled back do config change, u should not have any breaking change now. but for picking HOSTNAME for v1.2.1 looking for best possible method