Closed jadball closed 8 months ago
This seems to be failing due to a missing hdf5plugin on py 2.7 - @jonwright any ideas? I can push a new commit in this PR to fix if you know how
I think the problem is that dataset.py
now imports properties.py
which needs hdf5plugin
for its IO functions. We are only just now seeing this issue on Python 2.7 because we have some tests in test_datasets.py
that are now indirectly targeting code with HDF5 I/O
This may be solved by adding hdf5plugin as an explicit dependency to ImageD11?
We should have hdf5plugin in setup.py already: 'hdf5plugin==1.4.1 ; python_version < "3" and sys_platform == "win32" ', 'hdf5plugin ; python_version >= "3" ',
But I guess there is a bug there as it has nothing for python2 on non-windows...
I will merge and attempt to fix the CI later, the problem is not related...
Apologies for the monster commit! Key highlights below:
Grain
andDataSet
object.Grain
classDataSet
class (e.g getting peaks tables for you)iradon
blobcorrector.py
to correct a columnfile with a splineAll the diffs should be readable aside from
grain.py
which I accidentally linted (sorry!) - look at the bottom of the file for new stuff added.