search

FACG2 / getGitHub

1 stars 0 forks source link

Code Review #31

Closed ronanyeah closed 4 months ago

ronanyeah commented 7 years ago

Left some comments there. It looks great, it's running smoothly on Heroku. And with Travis! Very nice.

Design tips:

  1. Let the user know when the request starts. Put in a loading spinner or something.
  2. If the username doesn't exist, let the user know.

Code tips:

  1. Learn how to use map and reduce.
  2. Don't ever use for loops.
  3. Always use const unless you HAVE to use let.