File/Function names

[sultanassi95]

Hi,

• Starting with puplic, it should be --> public, please fix that typo, be careful :cry:

• In puplic/js the file index.js, we should consider conventions naming our files, the file contains the function fetch(), gitProject() and also gitUserData()

• • At this stage, I think it would be fair to call it logic.js instead of index.js.
• • also, in functions gitProject() and gitUserData()... git should be replaced with get, we can consider this to be a TYPO.
• • adding, function make_connection() is named using UNDERSCORE style, in JavaScript, it's well-known using the camelCase style naming any kind of variables also file names. It should be replaced with makeConnection() and simply connect()

In these lines of codes there are typos or convention related mistakes, find them out and please fix them:

https://github.com/FACG5/Later-team/blob/aaf09e86bb9ef670f8be49789e2e8d704cffb617/puplic/js/index.js#L4

• :information_source: Don't mix JS rules with HTML. using the underscore style in HTML is totally wanted.

https://github.com/FACG5/Later-team/blob/aaf09e86bb9ef670f8be49789e2e8d704cffb617/puplic/js/dom.js#L3

https://github.com/FACG5/Later-team/blob/aaf09e86bb9ef670f8be49789e2e8d704cffb617/puplic/js/dom.js#L5

https://github.com/FACG5/Later-team/blob/aaf09e86bb9ef670f8be49789e2e8d704cffb617/puplic/js/dom.js#L6

https://github.com/FACG5/Later-team/blob/aaf09e86bb9ef670f8be49789e2e8d704cffb617/puplic/js/dom.js#L20

https://github.com/FACG5/Later-team/blob/aaf09e86bb9ef670f8be49789e2e8d704cffb617/puplic/js/dom.js#L34

https://github.com/FACG5/Later-team/blob/aaf09e86bb9ef670f8be49789e2e8d704cffb617/puplic/js/dom.js#L94

• maybe append instead of add ? :thinking:

https://github.com/FACG5/Later-team/blob/aaf09e86bb9ef670f8be49789e2e8d704cffb617/puplic/js/dom.js#L99

• I go for select instead of get :1st_place_medal:

https://github.com/FACG5/Later-team/blob/aaf09e86bb9ef670f8be49789e2e8d704cffb617/puplic/js/dom.js#L103

• element doesn't really tell what is that function used for, maybe create does the job :sweat_smile:

I may have not included everything I've seen, you think you can hunt your own mistakes? :racehorse: