Open sultanassi95 opened 6 years ago
:tipping_hand_man: it's cool to have white lines between blocks that are considered to be quite big!
script
body
</body>
I have noticed that you haven't used the label with the input element in a proper way, but, if you mean to have a label that tells what the input element for, maybe you can use aria-label check this out
aria-label
I have noticed that you are hiding it in, but it's not really working! try doing that with CSS?! https://github.com/FACG5/Later-team/blob/aaf09e86bb9ef670f8be49789e2e8d704cffb617/puplic/js/dom.js#L13
Hi,
:tipping_hand_man: it's cool to have white lines between blocks that are considered to be quite big!
script
elements at the end of thebody
element not after it's closing tag</body>
https://github.com/FACG5/Later-team/blob/aaf09e86bb9ef670f8be49789e2e8d704cffb617/puplic/index.html#L63 https://github.com/FACG5/Later-team/blob/aaf09e86bb9ef670f8be49789e2e8d704cffb617/puplic/index.html#L65I have noticed that you haven't used the label with the input element in a proper way, but, if you mean to have a label that tells what the input element for, maybe you can use
aria-label
check this outI have noticed that you are hiding it in, but it's not really working! try doing that with CSS?! https://github.com/FACG5/Later-team/blob/aaf09e86bb9ef670f8be49789e2e8d704cffb617/puplic/js/dom.js#L13