search

FAForever / java-ice-adapter

A P2P connection proxy for Supreme Commander: Forged Alliance using ICE
MIT License
5 stars 12 forks source link

Add command line parameters to allow/block interfaces and/or ip addresses #24

Open BenKluwe opened 4 years ago

Geosearchef commented 4 years ago

How do you want to detect the interfaces to block? The ice adapter is not supposed to just use interfaces connected to the internet. It should also connect via local network, actually, it should work without the internet at all running a local FAF server.

BenKluwe commented 4 years ago

The interfaces to allow and block are user defined (See https://github.com/FAForever/downlords-faf-client/issues/1461), they need to be trickled through from the FAF client. This just exposes the ice4j harvester configuration (https://github.com/jitsi/ice4j/blob/e854e4efaf5dbb82e45028fceafe9d76ca93cb2a/doc/configuration.md) options to the command line. Even if an interface is bound, local connections are be able to be found because this is a routing problem for the OS and ICE to handle. As an example if a program is bound to ipv4 192.168.x.x and a connection attempt is made to 127.0.0.1 or 192.168.x.y, then the request still gets through to the other end.