search

FAForever / java-ice-adapter

A P2P connection proxy for Supreme Commander: Forged Alliance using ICE
MIT License
5 stars 12 forks source link

Grimplex can't connect to Ludmilla #29

Open Cheyans opened 3 years ago

Cheyans commented 3 years ago

Basically they can't connect to each other in the game lobby and as a result cannot play a game together.

I'll post the logs here: Grimplex logs: ice-adapter.log advanced-ice-adapter.log

Ludmilla logs:

Sheikah45 commented 3 years ago

There are a lot of invalid packets sent by Ludmilla in that log

ThomasHiatt1 commented 3 years ago

ice-adapter.log

Advanced ice adapter log is empy. Using Python client.

Sheikah45 commented 3 years ago

Seems like there are just a lot of timeouts in sending the candidates. It could be an issue with how the legacy client is formatting some of its messages as it seems like there is disagreement on what some of the bytes should be.

Geosearchef commented 3 years ago

It could be an issue with how the legacy client is formatting some of its messages as it seems like there is disagreement on what some of the bytes should be.

The traffic that is generating errors shouldn't be touched by the client. It looks to me as if some other device is transmitting packets to the same socket / port used by the adapter to communicate with the peer. Might also be some manipulation of the packets. Seems really weird, I've never seen this before nor thought it could even be an error. The arriving data doesn't seem to follow the protocol.

Geosearchef commented 2 years ago

Seems like this is the result of a bug in the ice connection's data protocol #31 .