FAForever / java-ice-adapter

A P2P connection proxy for Supreme Commander: Forged Alliance using ICE
MIT License
5 stars 12 forks source link

People leaving causes ICE to go completely nuts #55

Closed cdglitch closed 3 months ago

cdglitch commented 4 months ago

I've noticed some people have a way of leaving that causes either a desync or for ICE to break in really weird ways a good portion of the time. While they are disconnected in the game, I see other players as quiet and when they eventually get kicked from the game, I will then have a perfect connection to everyone except the P2P table shows for some reason I'm only getting data from other players every few seconds.

Changing coturn and enabling/disabling IPv6 doesnt help but debug does show the following which moves with the lag:

2024-05-12T23:49:46.803+02:00 DEBUG 830658 --- [FAF Client] [      JJsonPeer] c.f.c.fa.relay.ice.IceAdapterCallbacks   : Message from game: 'Bottleneck' '["ack","3215","45474,115577","5179.4"]'
2024-05-12T23:49:52.744+02:00 DEBUG 830658 --- [FAF Client] [      JJsonPeer] c.f.c.fa.relay.ice.IceAdapterCallbacks   : Message from game: 'Bottleneck' '["ack","3215","45474","11119.7"]'
2024-05-12T23:49:57.794+02:00 DEBUG 830658 --- [FAF Client] [      JJsonPeer] c.f.c.fa.relay.ice.IceAdapterCallbacks   : Message from game: 'Bottleneck' '["ack","3215","45474","16169.8"]'
2024-05-12T23:50:01.430+02:00 DEBUG 830658 --- [FAF Client] [      JJsonPeer] c.f.c.fa.relay.ice.IceAdapterCallbacks   : Message from game: 'BottleneckCleared' '[]'
2024-05-12T23:50:01.540+02:00 DEBUG 830658 --- [FAF Client] [      JJsonPeer] c.f.c.fa.relay.ice.IceAdapterCallbacks   : Message from game: 'Bottleneck' '["ack","3234","101807","19916.3"]'
2024-05-12T23:50:01.545+02:00 DEBUG 830658 --- [FAF Client] [      JJsonPeer] c.f.c.fa.relay.ice.IceAdapterCallbacks   : Message from game: 'BottleneckCleared' '[]'
2024-05-12T23:50:08.605+02:00 DEBUG 830658 --- [FAF Client] [      JJsonPeer] c.f.c.fa.relay.ice.IceAdapterCallbacks   : Message from game: 'Bottleneck' '["ack","3235","45474,115577","5659.5"]'
2024-05-12T23:50:13.864+02:00 DEBUG 830658 --- [FAF Client] [      JJsonPeer] c.f.c.fa.relay.ice.IceAdapterCallbacks   : Message from game: 'Bottleneck' '["ack","3235","45474","10918.0"]'
2024-05-12T23:50:19.350+02:00 DEBUG 830658 --- [FAF Client] [      JJsonPeer] c.f.c.fa.relay.ice.IceAdapterCallbacks   : Message from game: 'Bottleneck' '["ack","3235","45474","16404.4"]'
2024-05-12T23:50:24.350+02:00 DEBUG 830658 --- [FAF Client] [      JJsonPeer] c.f.c.fa.relay.ice.IceAdapterCallbacks   : Message from game: 'Bottleneck' '["ack","3235","45474","21404.7"]'
2024-05-12T23:50:25.049+02:00 DEBUG 830658 --- [FAF Client] [      JJsonPeer] c.f.c.fa.relay.ice.IceAdapterCallbacks   : Message from game: 'BottleneckCleared' '[]'
2024-05-12T23:50:25.049+02:00 DEBUG 830658 --- [FAF Client] [      JJsonPeer] c.f.c.fa.relay.ice.IceAdapterCallbacks   : Message from game: 'Bottleneck' '["ack","3236","24","22103.7"]'
2024-05-12T23:50:25.063+02:00 DEBUG 830658 --- [FAF Client] [      JJsonPeer] c.f.c.fa.relay.ice.IceAdapterCallbacks   : Message from game: 'BottleneckCleared' '[]'
2024-05-12T23:50:30.898+02:00 DEBUG 830658 --- [FAF Client] [      JJsonPeer] c.f.c.fa.relay.ice.IceAdapterCallbacks   : Message from game: 'Bottleneck' '["ack","3236","24","5840.6"]'
2024-05-12T23:50:35.752+02:00 DEBUG 830658 --- [FAF Client] [      JJsonPeer] c.f.c.fa.relay.ice.IceAdapterCallbacks   : Message from game: 'BottleneckCleared' '[]'

Not sure if this is known or if anyone wants help testing, but this is happening more and more lately.

Brutus5000 commented 3 months ago

Should be fixed by #56 (tests confirmed that CPU load massively decreased)