search

FAForever / server

The servercode for the Forged Alliance Forever lobby
http://www.faforever.com
GNU General Public License v3.0
66 stars 63 forks source link

Change map pool selection #952

Closed BlackYps closed 1 year ago

BlackYps commented 1 year ago

Changes the map pool selection from lowest rating to average rating as per request of the matchmaking team. Also fixes a minor bug I noticed where the slot pairs are only made based on mean rating which can lead to unexpected results for players with high deviation.

I feel like it would be good to have unit tests for this behavior, but I am not sure how to access the relevant variables to check their contents after the method has run.

Blodir commented 1 year ago

New to the codebase, but looks good to me!