search

FAForever / server

The servercode for the Forged Alliance Forever lobby
http://www.faforever.com
GNU General Public License v3.0
67 stars 62 forks source link

Possible to join TMM team when already in game/match launching state. #963

Open DotNetSimon opened 1 year ago

DotNetSimon commented 1 year ago

Describe the bug When you invite someone before you search, they can accept after/while searching. We had a friend joining our team while we just found a match.

To Reproduce Send invite, wait until match found and let other player accept the invite at that moment.

Log or error message This is my log file:

Expected behavior An error notification on the joining player's side that says something along the lines of "This team is already in the queue / already playing"

Screenshots If applicable, add screenshots to help explain your problem.

OS Linux or Windows

Wanna have the bug fixed quickly? Visit Issue hunt... Issue hunt

Askaholic commented 1 year ago

Probably makes sense to error out in that case. Nothing bad will happen with the searching or matching though since the searches are separate from the party. If you find a match, the player who joined late will simply not be included in the match. That’s probably a bit confusing from the user perspective though.

benjamin-lawson commented 6 months ago

@Askaholic Would we want the behavior to be that if that party is currently searching, found a match, or currently in a match, would not be able to join the party? I think that would be more clear than to allow a player into a party but they aren't pulled in.

Askaholic commented 5 months ago

Yep, I think that makes sense too.