search

FAForever / website

FAForever's Website
http://www.faforever.com
MIT License
21 stars 37 forks source link

Report User Broken #488

Closed fcaps closed 1 year ago

fcaps commented 1 year ago

due to poor error-handling in the app, report user is crashing the container (or the node process). Reason: API needs an authenticated user, and node is not providing it + poor error-handling.

 /code/routes/views/account/post/report.js:86
website-website-1  |           flash.messages = [{msg: 'Error while submitting the report form: '+e.toString()}];
website-website-1  |                                                                                ^
website-website-1  |
website-website-1  |     TypeError: Cannot read properties of null (reading 'toString')
website-website-1  |         at module.exports (/code/routes/views/account/post/report.js:86:76)
website-website-1  |         at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
fcaps commented 1 year ago

fixed some issues with https://github.com/FAForever/website/pull/499 still offenders and suggests are empty